Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several container related fixes #169

Merged
merged 7 commits into from
Nov 25, 2023
Merged

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #169 (6b4ec82) into master (185d699) will increase coverage by 0.50%.
The diff coverage is 93.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   84.68%   85.18%   +0.50%     
==========================================
  Files          96       97       +1     
  Lines        5789     5942     +153     
  Branches      621      631      +10     
==========================================
+ Hits         4902     5061     +159     
+ Misses        712      706       -6     
  Partials      175      175              
Flag Coverage Δ
Linux 84.76% <93.41%> (+0.63%) ⬆️
Windows 76.43% <31.87%> (-1.17%) ⬇️
macOS ?
py3.10 84.82% <93.41%> (+0.56%) ⬆️
py3.7 84.06% <92.99%> (+0.65%) ⬆️
py3.8 84.89% <93.41%> (+0.63%) ⬆️
py3.9 84.91% <93.41%> (+0.56%) ⬆️
pytest-7.3.0 84.89% <93.41%> (+0.56%) ⬆️
pytest-7.4.0 84.89% <93.41%> (+0.56%) ⬆️
salt-3005.0 84.74% <93.41%> (+0.63%) ⬆️
salt-3006.0 84.88% <93.41%> (+0.56%) ⬆️
src 77.13% <100.00%> (+0.69%) ⬆️
tests 96.27% <92.86%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/saltfactories/daemons/container.py 79.74% <100.00%> (+5.42%) ⬆️
...gration/factories/daemons/container/test_master.py 100.00% <100.00%> (ø)
...integration/factories/daemons/ssh/test_salt_ssh.py 100.00% <100.00%> (ø)
...ts/integration/factories/daemons/sshd/test_sshd.py 100.00% <100.00%> (ø)
...ntegration/factories/daemons/container/conftest.py 96.00% <95.00%> (-4.00%) ⬇️
...gration/factories/daemons/container/test_minion.py 97.44% <95.75%> (+1.01%) ⬆️
tests/conftest.py 83.79% <50.00%> (-2.98%) ⬇️
...tories/daemons/container/test_container_factory.py 95.66% <85.30%> (-4.34%) ⬇️

... and 4 files with indirect coverage changes

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…the ``SaltMinion`` and the ``SaltMaster`` classes when ``pull_before_start`` is True

Fixes saltstack#168

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the master branch 2 times, most recently from 6ec3046 to 6b4ec82 Compare November 25, 2023 21:30
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch enabled auto-merge (rebase) November 25, 2023 21:55
@s0undt3ch s0undt3ch disabled auto-merge November 25, 2023 21:55
@s0undt3ch s0undt3ch merged commit 297946e into saltstack:master Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant