Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repo.saltstack.com URLs for Python 3 packages (#364) #397

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Fix repo.saltstack.com URLs for Python 3 packages (#364) #397

merged 1 commit into from
Feb 1, 2019

Conversation

myii
Copy link
Member

@myii myii commented Jan 29, 2019

From findings in #364 (comment):

Further issues (e.g. lack of PY3 support)

Having collated the URLs, I've identified further issues. For example, the formula does not currently support PY3 installations. It would be advantageous to resolve these issues concurrently.

This PR fixes the PY3 links for the following URLs:

Debian

# Pin Py Key Repo Direct
2 Latest 3 https://repo.saltstack.com/py3/debian/9/amd64/latest/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/amd64/latest stretch main
5 Major 3 https://repo.saltstack.com/py3/debian/9/amd64/2018.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/amd64/2018.3 stretch main
8 Minor 3 https://repo.saltstack.com/py3/debian/9/amd64/archive/2018.3.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/amd64/archive/2018.3.3 stretch main

Red Hat / CentOS

# Pin Py Key Repo Direct
17 Minor 3 https://repo.saltstack.com/py3/redhat/7/x86\_64/archive/2018.3.3/SALTSTACK-GPG-KEY.pub https://repo.saltstack.com/py3/redhat/$releasever/$basearch/archive/2018.3.3

Ubuntu

# Pin Py Key Repo Direct
21 Latest 3 https://repo.saltstack.com/py3/ubuntu/18.04/amd64/latest/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/18.04/amd64/latest bionic main
22 Latest 3 https://repo.saltstack.com/py3/ubuntu/16.04/amd64/latest/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/16.04/amd64/latest xenial main
26 Major 3 https://repo.saltstack.com/py3/ubuntu/18.04/amd64/2018.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/18.04/amd64/2018.3 bionic main
27 Major 3 https://repo.saltstack.com/py3/ubuntu/16.04/amd64/2018.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/16.04/amd64/2018.3 xenial main
31 Minor 3 https://repo.saltstack.com/py3/ubuntu/18.04/amd64/archive/2018.3.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/18.04/amd64/archive/2018.3.3 bionic main
32 Minor 3 https://repo.saltstack.com/py3/ubuntu/16.04/amd64/archive/2018.3.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/ubuntu/16.04/amd64/archive/2018.3.3 xenial main

Raspbian

# Pin Py Key Repo Direct
56 Latest 3 https://repo.saltstack.com/py3/debian/9/armhf/latest/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/armhf/latest stretch main
59 Major 3 https://repo.saltstack.com/py3/debian/9/armhf/2018.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/armhf/2018.3 stretch main
62 Minor 3 https://repo.saltstack.com/py3/debian/9/armhf/archive/2018.3.3/SALTSTACK-GPG-KEY.pub http://repo.saltstack.com/py3/debian/9/armhf/archive/2018.3.3 stretch main

@myii myii requested a review from aboe76 January 29, 2019 15:08
aboe76
aboe76 approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@aboe76 aboe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I don't see any issues.

@myii
Copy link
Member Author

myii commented Jan 29, 2019

@aboe76 Thanks for taking the time to review.

@myii
Copy link
Member Author

myii commented Feb 1, 2019

@aboe76 OK to merge or shall we wait for further reviews?

@aboe76 aboe76 merged commit 5eee4c6 into saltstack-formulas:master Feb 1, 2019
@aboe76
Copy link
Member

aboe76 commented Feb 1, 2019

@myii merged it, thanks for this.

@myii myii deleted the PR_364-py3 branch February 1, 2019 16:38
@myii
Copy link
Member Author

myii commented Feb 1, 2019

@aboe76 Thanks for the merge.

@myii myii mentioned this pull request Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboe76 aboe76 aboe76 approved these changes

@jochumdev jochumdev Awaiting requested review from jochumdev

@javierbertoli javierbertoli Awaiting requested review from javierbertoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myii @aboe76