Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated iteritems() method not forward-compatible with Python 3 #296

Closed
aboe76 opened this issue Feb 16, 2017 · 0 comments
Closed

Deprecated iteritems() method not forward-compatible with Python 3 #296

aboe76 opened this issue Feb 16, 2017 · 0 comments

Comments

@aboe76
Copy link
Member

aboe76 commented Feb 16, 2017

the salt-formula uses iteritems in map.jinja

see:
https://github.com/saltstack-formulas/salt-formula/blob/master/salt/map.jinja#L5

Formulas iterating over dictionaries should use the items() method instead of iteritems() because the latter method has been removed from Python 3. While the items() method in Python 2 uses more memory than iteritems(), these dictionaries are typically small (e.g., sets of settings from Pillar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant