Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt_cloud_certs broken by pull #106 ("Don't overwrite salt variable") #113

Closed
xenophonf opened this issue Mar 29, 2015 · 5 comments
Closed

Comments

@xenophonf
Copy link
Contributor

In context, see cb3aa80#diff-cc4a14e8ec642fa03a6038c172bd52b0L46.

The original Pillar lookup had nothing to do with the salt variable that was renamed to salt_settings. Instead, it was querying the value of the Pillar key "salt_cloud_certs". This commit changes the Pillar key to "salt:salt_cloud_certs" without also updating https://github.com/saltstack-formulas/salt-formula/blob/master/salt/files/key and https://github.com/saltstack-formulas/salt-formula/blob/master/pillar.example, and it violates POLA in that it breaks working salt-cloud configurations managed by salt-formula.

@iggy
Copy link
Contributor

iggy commented Mar 29, 2015

Good catch. I'll send a patch to fix it up.

@xenophonf
Copy link
Contributor Author

@iggy, I just filed a pull request that reverts the problematic change:

#114

@iggy
Copy link
Contributor

iggy commented Mar 30, 2015

Thanks. I hoped to get to it over the weekend, but I got hung up on other stuff (garage doors don't paint themselves :/ )

Looks good to me 👍

@gravyboat
Copy link
Contributor

I'll merge this then.

@xenophonf
Copy link
Contributor Author

Awesome. Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants