Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-formula: next generation #8

Open
bebosudo opened this issue Oct 25, 2018 · 13 comments
Open

django-formula: next generation #8

bebosudo opened this issue Oct 25, 2018 · 13 comments
Assignees

Comments

@bebosudo
Copy link

Hi all,
I wrote another django-formula, which provides more options to customize a django webapp.
Moreover, I wrote a working example of deployment.

https://github.com/bebosudo/django-formula/
https://groups.google.com/forum/#!topic/salt-users/rMeG9VirEns

I propose to add it as a ng version, as in the postgres-formula.
What do you think?

@aboe76
Copy link
Member

aboe76 commented Feb 14, 2019

@bebosudo sorry to see this issue, so late...

Will look into it.

@aboe76 aboe76 self-assigned this Feb 14, 2019
@bebosudo
Copy link
Author

Hi @aboe76, I'd like to extend the example further with a pipenv section.
Feel free to comment my fork.

@bebosudo
Copy link
Author

@aboe76 any news?

@myii
Copy link
Member

myii commented Feb 19, 2019

@bebosudo Please continue your good work. We're making substantial changes across all SaltStack Formulas right now, to improve the quality and consistency of formulas. For example of some of the changes we're working through, please see saltstack-formulas/template-formula#21.

Once we've managed to start applying automatic release tagging and the other basic structures, we can look at how to incorporate ng formulas. For another example of a formula working towards this, refer to the conversation surrounding the comment: saltstack-formulas/apache-formula#251 (comment).

@aboe76
Copy link
Member

aboe76 commented Feb 19, 2019

@bebosudo, @myii is right, we are changing the saltstack-formulas hopefully for the better to accomodate these kind of changes, with semver solution, instead of ng

@myii
Copy link
Member

myii commented Mar 29, 2019

@aboe76 Our changes are going to take some time, perhaps we should put this in a new develop-v1.0.0 branch, like has been done for the apache-formula? One other thought about this (for both formulas) -- don't we want to set this new branch as the default, so that PRs are provided for the new branch?

@aboe76
Copy link
Member

aboe76 commented Mar 30, 2019

@myii I see no problem with that.

@myii
Copy link
Member

myii commented Mar 30, 2019

Thanks, @aboe76.
@bebosudo OK, I've created that branch. Feel free to "replace" it with your formula in a new PR.

@myii
Copy link
Member

myii commented Nov 23, 2019

@bebosudo Are you still interesting in providing this? We could continue with the branch or we could even implement semantic-release in this formula, to make it available immediately.

@bebosudo
Copy link
Author

Hi, I'm still interested in developing that formula; I'll try to find time this week.

@myii
Copy link
Member

myii commented Nov 25, 2019

@bebosudo Thanks, I'll try to get semantic-release implemented before then, so that we can have a cleaner conversion.

@myii
Copy link
Member

myii commented Nov 25, 2019

@bebosudo OK, semantic-release has been merged in #9 and I've removed the extra branch develop-v1.0.0. I'll start the deprecation notices soon, so that any existing users are informed that the formula is about to be significantly modified.

@myii
Copy link
Member

myii commented Dec 9, 2019

Another reason to get the current formula replaced: #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants