Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans for v8 (Node v20+, esm-only) #1263

Open
Shinigami92 opened this issue Aug 31, 2024 · 6 comments
Open

Plans for v8 (Node v20+, esm-only) #1263

Shinigami92 opened this issue Aug 31, 2024 · 6 comments
Assignees
@Shinigami92
Labels
breaking change Cannot be merged when next version is not a major release help wanted Extra attention is needed
Milestone
v8.0

Comments

@Shinigami92
Copy link
Collaborator

Shinigami92 commented Aug 31, 2024 •
edited
Loading

While trying to support esm alongside cjs, more and more issues popping up 😢

I think the time has come to move forward and leave the cjs world behind. node-pg-migrate is also mostly anyways a CLI tool, and so hopefully it wont hurt the community that much.
However, as a first pre-step I setup a v7 branch, where in worst case we can e.g. backport features if possible.

Together with esm-only support, I will also remove support for Node v18, because import.meta.dirname is only a thing since Node v20.11.0.

Additionally TypeScript v4 support will be dropped.

Feel free to start some discussions below and provide feedback or help.
@Shinigami92 Shinigami92 added this to the v8.0 milestone Aug 31, 2024
@Shinigami92 Shinigami92 self-assigned this Aug 31, 2024
@Shinigami92 Shinigami92 pinned this issue Aug 31, 2024
@Shinigami92 Shinigami92 mentioned this issue Aug 31, 2024
Open
@Shinigami92 Shinigami92 added the breaking change Cannot be merged when next version is not a major release label Aug 31, 2024
@JakubGodlewski1
Copy link

So when do you plan to release the changes/v8?

@Shinigami92
Copy link
Collaborator Author

So when do you plan to release the changes/v8?

Not sure at all, but it could even be after Node v18 reached EOL -> April 2025

@Shinigami92 Shinigami92 mentioned this issue Jan 16, 2025
Closed
@Shinigami92
Copy link
Collaborator Author

A first experimental release is available at https://www.npmjs.com/package/node-pg-migrate/v/8.0.0-experimental-1328-1 containing the commit 4e91913 from #1328.
Please report all bugs to that PR.

@Shinigami92
Copy link
Collaborator Author

Shinigami92 commented Feb 17, 2025 •
edited
Loading

There is already a working https://github.com/salsita/node-pg-migrate/releases/tag/v8.0.0-rc.0

However I'm thinking about to wait for TS 5.8 and its erasableSyntaxOnly feature. Also I could still wait for official Node v18 drop, because there is theoretically no rush needed to immediately release it.
Additionally there might still be some things in the documentation that is off now. Feel free to help and contribute if you found something like that. I appreciate help from the community 🙏

@Shinigami92 Shinigami92 added the help wanted Extra attention is needed label Feb 17, 2025
@Infonautica
Copy link

Thank you for for the release candidate! Btw, TS 5.8 seems to be out already: https://devblogs.microsoft.com/typescript/announcing-typescript-5-8/

@Shinigami92
Copy link
Collaborator Author

Thank you for for the release candidate! Btw, TS 5.8 seems to be out already: devblogs.microsoft.com/typescript/announcing-typescript-5-8

Thanks for your interest and telling me 😸
Did you know that #1363 is already available in v8.0.0-rc.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release help wanted Extra attention is needed
Projects
None yet
Milestone
v8.0
Development

No branches or pull requests
3 participants
@Infonautica @Shinigami92 @JakubGodlewski1