Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Swedish bath waters between API badplatsen.havochvatten.se/badplatsen/api 2686 and uploaded bath waters 438 #18

Closed
salgo60 opened this issue May 13, 2021 · 6 comments

Comments

@salgo60
Copy link
Owner

salgo60 commented May 13, 2021

We find 439 Swedish bathing waters in https://discomap.eea.europa.eu/Bathingwater/

image

In API badplatsen/api/feature we have 2686 and in Wikidata we have additional some in this projects > 2700

image

@soleildeminuit
Copy link
Contributor

The badplatsen/api/feature API has an attribute euType (a boolean flag) that, according to the docs, indicates whether the site is to reported to EU or not (in Swedish "Flagga som anger om badet är ett EU bad eller ej")

table(testLocations$euType)

FALSE TRUE
2155 440

@salgo60
Copy link
Owner Author

salgo60 commented May 15, 2021

Good catch then the question is

  • do we have Nutskod for 2155
  • do we have bathingWaterIdentifier for just 440 or 2155

I guess https://dd.eionet.europa.eu/dataelements/99263 states that "Must be a valid bathing water identifier in the "WFDProtectedArea" registry"

Next step: we need to speak with people administrating the Swedish database and understand if we need one or two identifiers in Wikidata for supporting EUbaths and Swedish bath waters with euType = False

  • I guess if we start use the suggested bathingWaterIdentifier field for things not registered at the "WFDProtectedArea" registry" we are just creating a mess..a rose is a rose is a rose ;-)

@soleildeminuit
Copy link
Contributor

I agree, best to stick to established nomenclature...We do have nutsCode for all of them, but the term bathingWaterIdentifier does not exist in the API. There are more test locations/sites then what I mentioned, the import fails for a couple of dozens, probably due to data quality issues.

@soleildeminuit
Copy link
Contributor

Not all of the nutsCode has an associated test location profile, for example:
https://badplatsen.havochvatten.se/badplatsen/api/testlocationprofile/SE0930861000004814

@salgo60
Copy link
Owner Author

salgo60 commented May 15, 2021

Do we have a good specification of the NUTScode?

In Wikidata we call it Property:P605 and have a regexp [A-Z]{2}[A-Z0-9]{0,3}
image

and a formatter URL http://dd.eionet.europa.eu/vocabularyconcept/common/nuts/$1
==>

@salgo60
Copy link
Owner Author

salgo60 commented May 15, 2021

@AndersElias
SE0930861000004814 see #33

  • do you have a list of them I guess all of them are errors in Wikidata...

Update found those 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants