Skip to content

Commit 028cc20

Browse files
committed
fix: Pin protobuf version to avoid seg fault on some machines
Signed-off-by: Danny C <d.chiao@gmail.com>
1 parent 1695c13 commit 028cc20

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ kill-trino-locally:
353353
cd ${ROOT_DIR}; docker stop trino
354354

355355
install-protoc-dependencies:
356-
pip install --ignore-installed protobuf grpcio-tools==1.47.0 mypy-protobuf==3.1.0
356+
pip install --ignore-installed protobuf==4.23.4 grpcio-tools==1.47.0 mypy-protobuf==3.1.0
357357

358358
install-feast-ci-locally:
359359
pip install -e ".[ci]"

setup.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@
5555
"pandas>=1.4.3,<2",
5656
# For some reason pandavro higher than 1.5.* only support pandas less than 1.3.
5757
"pandavro~=1.5.0",
58-
"protobuf<5,>3.20",
58+
# Higher than 4.23.4 seems to cause a seg fault
59+
"protobuf<4.23.4,>3.20",
5960
"proto-plus>=1.20.0,<2",
6061
"pyarrow>=4,<12",
6162
"pydantic>=1,<2",

0 commit comments

Comments
 (0)