Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger category tests #8001

Closed
nthiery opened this issue Jan 19, 2010 · 7 comments
Closed

Stronger category tests #8001

nthiery opened this issue Jan 19, 2010 · 7 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Jan 19, 2010

  • More category tests: _test_category, _test_elements
  • Improvements to TestSuite
    • Partial support for nested test suites
    • Support for basic TestSuite(x) for x any Python object
  • Added TestSuite call for Spec and ref to Fix TestSuite failures for schemes #7946
  • Corresponding doctest updates

Depends on #7921

CC: @sagetrac-sage-combinat

Component: doctest coverage

Keywords: TestSuite

Author: Nicolas M. Thiéry

Reviewer: Florent Hivert

Merged: sage-4.3.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/8001

@nthiery nthiery added this to the sage-4.3.2 milestone Jan 19, 2010
@nthiery nthiery self-assigned this Jan 19, 2010
@nthiery
Copy link
Contributor Author

nthiery commented Jan 19, 2010

Attachment: trac_8001-categories_testsuite-nt.patch.gz

@robertwb
Copy link
Contributor

comment:2

I briefly glanced at the patch when doing #7921, and what I saw looks good (though I didn't read it all thoroughly enough to call it a review).

@hivert
Copy link

hivert commented Jan 23, 2010

comment:3

I'm uploading a small trivial review patch. Here are the comment:

  • Add a missing "`";
  • Improve the layout of an enumeration;
  • replace ZZ._tester with QQ._tester to show that the gadget is automatically attached (Noting to do with the previous call on ZZ.

Otherwise the patch is ready to go.

Nicolas: You can add positive review once you had a look on my review patch.

@hivert
Copy link

hivert commented Jan 23, 2010

@nthiery
Copy link
Contributor Author

nthiery commented Jan 23, 2010

comment:4

Replying to @hivert:

I'm uploading a small trivial review patch. Here are the comment:

  • Add a missing "`";
  • Improve the layout of an enumeration;
  • replace ZZ._tester with QQ._tester to show that the gadget is automatically attached (Noting to do with the previous call on ZZ.

Otherwise the patch is ready to go.

Thanks for the review!

Nicolas: You can add positive review once you had a look on my review patch.

Done!

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 23, 2010

Merged: sage-4.3.2.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants