-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change $MKDIR to 'mkdir' in pari #7901
Comments
Author: David Kirkby |
This comment has been minimized.
This comment has been minimized.
comment:3
The patch of spkg-install looks ok. Maybe the SPKG.txt should be brought up to date. See also: #7738 Dave, can you fix that? Jaap |
Reviewer: Jaap Spies |
comment:4
OK I've recreated the spkg, which again can be found at http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg Please check it again. I've attached the Mercurial patch, which overwrites the old one. |
Attachment: pari-variables-to-commands.patch.gz Updated patch to fix spkg-install and SPKG.txt |
comment:5
All fixed. Positive review. Jaap |
Merged: sage-4.3.1.rc0 |
It was agreed recently that variables would not be used for very common commands like MV, MKDIR etc.
#7818 usets these, so this package may break. The fix is to simply replace $MKDIR with 'mkdir' in spkg-install.
An updated .spkg can be found at
http://boxen.math.washington.edu/home/kirkby/portability/pari-2.3.3.p7/pari-2.3.3.p7.spkg
CC: @jaapspies @jhpalmieri
Component: build
Author: David Kirkby
Reviewer: Jaap Spies
Merged: sage-4.3.1.rc0
Issue created by migration from https://trac.sagemath.org/ticket/7901
The text was updated successfully, but these errors were encountered: