Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coxeter groups: more Bruhat and weak order features #7753

Closed
nthiery opened this issue Dec 23, 2009 · 7 comments
Closed

Coxeter groups: more Bruhat and weak order features #7753

nthiery opened this issue Dec 23, 2009 · 7 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Dec 23, 2009

New methods:

  • bruhat_le (code inspired from code by Daniel Bump)
  • weak_le
  • bruhat_poset (finite Coxeter groups)
  • weak_poset (finite Coxeter groups)

Improved doctests for related methods

(Trivially) depends on #7842

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: Bruhat order, Weak order

Author: Nicolas M. Thiéry, Daniel Bump

Reviewer: Daniel Bump

Merged: sage-4.3.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7753

@nthiery nthiery added this to the sage-4.3.1 milestone Dec 23, 2009
@nthiery nthiery self-assigned this Dec 23, 2009
@dwbump
Copy link
Mannequin

dwbump mannequin commented Jan 2, 2010

comment:2

This patch implements the bruhat_order as a cached method and is badly needed.

With Sage 4.3, this raises an exception at the test in coxeter_groups.py, line 1010.

The definition of Q could be rewritten:

W = WeylGroup("B3")
sage: fcn = lambda x,y : x.bruhat_le(y)
sage: Q=Poset((W.list(),fcn))

Maybe the ?!? should be removed from the # long time directive
a couple of lines later since it is unclear what it means.

@dwbump dwbump mannequin added s: needs work and removed s: needs review labels Jan 2, 2010
@dwbump dwbump mannequin changed the title Coxeter groups: more Bruhat and weak order features Coxeter groups: more Bruhat and weak order features [with patch, needs work] Jan 2, 2010
@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor Author

nthiery commented Jan 4, 2010

comment:3

Replying to @dwbump:

This patch implements the bruhat_order as a cached method and is badly needed.

With Sage 4.3, this raises an exception at the test in coxeter_groups.py, line 1010.

Oops, I forgot that this depended on another patch; now #7842. As you mention, this dependency is trivial though, so we can also work around it if #7842 is not merged instantly.

Maybe the ?!? should be removed from the # long time directive
a couple of lines later since it is unclear what it means.

Fixed, and updated the # long time around that line. I was just surprised by how much time this was taking. We need more Weyl group optimizations!

@nthiery nthiery changed the title Coxeter groups: more Bruhat and weak order features [with patch, needs work] Coxeter groups: more Bruhat and weak order features Jan 4, 2010
@nthiery
Copy link
Contributor Author

nthiery commented Jan 4, 2010

Updated timings w.r.t. #7754 which is already in Sage

@dwbump
Copy link
Mannequin

dwbump mannequin commented Jan 7, 2010

comment:4

Attachment: trac_7753_root_systems-bruhat_order-nt.patch.gz

By now this code is tested a lot, at least for finite Weyl groups, and
the previous reviewer comments were addressed. I am changing the
status to positive review.

@dwbump dwbump mannequin added s: positive review and removed s: needs review labels Jan 7, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 13, 2010

Merged: 4.3.1.alpha2

@rlmill rlmill mannequin removed the s: positive review label Jan 13, 2010
@rlmill rlmill mannequin closed this as completed Jan 13, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 13, 2010

Changed merged from 4.3.1.alpha2 to sage-4.3.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant