include new version of sagenb (0.4.6)

[williamstein]

It's here:

http://wstein.org/home/wstein/patches/sagenb/sagenb-0.4.5.spkg

(and now updated to 0.4.6 here):

http://wstein.org/home/wstein/patches/sagenb/sagenb-0.4.6.spkg

Component: notebook

Author: William Stein

Reviewer: Mitesh Patel, Tim Dumol

Merged: sage-4.3.rc0

Issue created by migration from https://trac.sagemath.org/ticket/7625

[williamstein]

comment:2

#7495: William Stein and Mitesh Patel: notebook: fix massive security vulnerability and get rid of all possible "internal server errors" when doing "Data --> Upload or attach file [Reviewed by Mitesh Patel]
#3619: William Stein: notebook -- record date & time each user logs in [Reviewed by Tim Dumol]
#3849: William Stein and Mitesh Patel: notebook --get rid of internal server errors when uploading a worksheet [Reviewed by Tim Dumol]
#7402: Tim Dumol: notebook -- Use `pkg_resources` to locate `DATA` directory [Reviwed by Mitesh Patel]
#7428: Mitesh Patel: worksheets listed on published list only after they are republished, but not after initial publication [Reviewed by Tim Dumol]
#7444: Mitesh Patel: Broken: searching published worksheets after publishing a worksheet for the first time [Reviewed by Tim Dumol]
#7467: Tim Dumol: Make SageNB use `setuptools` instead of `distutils` [Reviewed by Mitesh Patel]
#7390: Mitesh Patel: HTML notebook test report [Reviewed by Tim Dumol]
#7470: Tim Dumol: SageNB -- Minor docstring fixes for `js.py` [Reviewed by Mitesh Patel]

[williamstein]

comment:3

I just posted the release notes for this above.

[qed777]

comment:4

This looks good to me, apart from the comedy of errors that is the notebook settings page. Also, 14 out of 15 Selenium tests still pass (cf. #7455).

I think Dr. Palmieri reviewed #7470.

Positive review, pending Tim's confirmation?

[qed777]

Reviewer: Mitesh Patel

[williamstein]

comment:5

Hi,

I merged in 9 more patches to make sagenb-0.4.6, which does fix the notebook settings page issues. We should release sagenb-0.4.6 instead:

http://wstein.org/home/wstein/patches/sagenb/sagenb-0.4.5.spkg

#5100: Tim Dumol: worksheets: can't empty the trash (safari only?) [Reviewed by John Palmieri and William Stein]
#3733: William Stein: document notebook.css; I also sphinxified the notebook? docstring [Reviewed by Tim Dumol]
#7433: Tim Dumol: Changing title of worksheet changes title of corresponding published worksheet [Reviewed by William Stein]
#7455: Tim Dumol: Searching on Log page does not work [Reviewed by William Stein]
#4714: Mitesh Patel: use easy/load.js when loading jsmath in the notebook [Reviewed by William Stein]
#7267: Mitesh Patel: Add a compact color picker to SageNB [Reviewed by William Stein and Tim Dumol]
#7376: Mitesh Patel: searching published worksheets does not work to just search for username [Reviewed by William Stein]
#7447: Mitesh Patel: SageNB version and install date / time [Reviewed by William Stein]
#7611: Tim Dumol: Minor ReST improvements for the notebook object documentation [Reviewed by William Stein]

[williamstein]

comment:6

Here I meant http://wstein.org/home/wstein/patches/sagenb/sagenb-0.4.6.spkg of course.

[qed777]

comment:7

All Se tests now pass. But I'm a bit too tired right now to do further checking.

Potential feature for the log page: A check box next to each cell, so the user can select a subset for a new worksheet?

[TimDumol]

Changed reviewer from Mitesh Patel to Mitesh Patel, Tim Dumol

[TimDumol]

comment:8

Se tests pass on my machine as well. Nothing broke in my worksheets either.

Since Patel also agrees, I'll mark this with a positive review.

[mwhansen]

Merged: sage-4.3.rc0

[mwhansen]

Author: William Stein

[TimDumol]

comment:10

Correct me if I'm mistaken, but is #7467 actually included? I cannot find it in the merge log.

[williamstein]

comment:11

Replying to @TimDumol:

Correct me if I'm mistaken, but is #7467 actually included? I cannot find it in the merge log.

Oh crap, you're right. I don't know how I made that mistake. Here's a sagenb-0.4.7 that includes that and one other patch I merged:

http://wstein.org/home/wstein/patches/sagenb/sagenb-0.4.7.spkg

SAGENB-0.4.7
#7467: Tim Dumol: Make SageNB use `setuptools` instead of `distutils` [Reviewed by Mitesh Patel]
#7628: Mitesh Patel: Error on account creation still creates (half of) an account [Reviewed by William Stein]

[mwhansen]

comment:13

Looks good.