Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation in sage/combinat/backtrack.py #6190

Closed
rbeezer mannequin opened this issue Jun 2, 2009 · 6 comments
Closed

Fix documentation in sage/combinat/backtrack.py #6190

rbeezer mannequin opened this issue Jun 2, 2009 · 6 comments
Assignees
@rbeezer
Labels
c: combinatorics p: minor / 4 t: bug
Milestone
sage-4.0.1

Comments

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jun 2, 2009

Four doctests introduced in #6000 need proper indentations, plus some lists, and some spelling.

CC: @loefflerd

Component: combinatorics

Author: David Loeffler

Reviewer: Rob Beezer

Merged: 4.0.1.rc0

Issue created by migration from https://trac.sagemath.org/ticket/6190
@rbeezer rbeezer mannequin added this to the sage-4.0.2 milestone Jun 2, 2009
@rbeezer rbeezer mannequin added c: combinatorics labels Jun 2, 2009
@rbeezer rbeezer mannequin self-assigned this Jun 2, 2009
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 2, 2009

comment:1

Attachment: trac_6190.patch.gz

Here's a patch.

@loefflerd loefflerd mannequin added the s: needs review label Jun 2, 2009
@rbeezer
Copy link
Mannequin Author

rbeezer mannequin commented Jun 3, 2009

comment:2

Hi David,

Thanks for the changes. I'd intended to do them, since I understand ReST better now than I did a few weeks ago, but you've done a nice job with it.

Passes doctests on this one file, which it should since all of the changes are to documentation (not code, or tests). HTML version builds without errors and looks very nice.

Positive review.

Rob

@rbeezer rbeezer mannequin modified the milestones: sage-4.0.2, sage-4.0.1 Jun 3, 2009
@mwhansen
Copy link
Contributor

mwhansen commented Jun 3, 2009

comment:3

Merged in 4.0.1.rc0.

@mwhansen mwhansen closed this as completed Jun 3, 2009
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Reviewer: Rob Beezer

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Author: David Loeffler

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Merged: 4.0.1.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbeezer rbeezer

Labels
c: combinatorics p: minor / 4 t: bug
Projects
None yet
Milestone
sage-4.0.1
Development

No branches or pull requests
1 participant
@mwhansen