Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outrageously long test in cyclic covers #38827

Open
orlitzky opened this issue Oct 19, 2024 · 4 comments
Open

Outrageously long test in cyclic covers #38827

orlitzky opened this issue Oct 19, 2024 · 4 comments
Labels

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Oct 19, 2024

Edit: deleted the first one which isn't reproducible in CPU time
Edit: and also the second one, which is #35479

File "src/sage/schemes/cyclic_covers/cycliccover_finite_field.py", line 1140, in sage.schemes.cyclic_covers.cycliccover_finite_field.CyclicCover_finite_field.frobenius_polynomial
Warning, slow doctest:
    CyclicCover(3, h).frobenius_polynomial()  # long time
Test ran for 1046.50 s, check ran for 0.00 s

And with CPU time (on a different machine):

File "src/sage/schemes/cyclic_covers/cycliccover_finite_field.py", line 1140, in sage.schemes.cyclic_covers.cycliccover_finite_field.CyclicCover_finite_field.frobenius_polynomial
Warning, slow doctest:
    CyclicCover(3, h).frobenius_polynomial()  # long time
Test ran for 248.93s cpu, 250.58s wall
Check ran for 0.00s cpu, 0.00s wall
@mantepse
Copy link
Contributor

Could it be that there is a performance regression?

@orlitzky
Copy link
Contributor Author

The main problem is that we aren't measuring how long the tests take in a meaningful way, but that will hopefully be fixed soon in #36226

I don't think there was a regression, I think they were always this slow.

@DaveWitteMorris
Copy link
Member

Related issue: I think #35479 is the silver medalist.

@orlitzky orlitzky changed the title A few outrageously long tests Outrageously long test in cyclic covers Feb 19, 2025
@orlitzky
Copy link
Contributor Author

Related issue: I think #35479 is the silver medalist.

Thanks, I updated the title/description. (Now that cputime is reported by default, anyone can look at the CI annotations to get a list of slow tests. I think I was extra frustrated when I reported these.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants