Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.quadratic_forms: Remove module-level imports from number_fields, sage.symbolic, sage.functions #35243

Closed
mkoeppe opened this issue Mar 7, 2023 · 0 comments · Fixed by #35305
Closed

sage.quadratic_forms: Remove module-level imports from number_fields, sage.symbolic, sage.functions #35243

mkoeppe opened this issue Mar 7, 2023 · 0 comments · Fixed by #35305
Assignees
@mkoeppe
Labels
c: number fields c: quadratic forms t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 7, 2023

For example by

  • moving is_fundamental_discriminant to sage.arith.
  • moving import from sage.rings.padics.factory into a method

This is part of:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkoeppe mkoeppe

Labels
c: number fields c: quadratic forms t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

sage.quadratic_forms: Modularization fixes for imports mkoeppe/sage
1 participant
@mkoeppe