Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when floor dividing in infinite polynomial ring #34535

Closed
trevorkarn opened this issue Sep 15, 2022 · 15 comments
Closed

Segfault when floor dividing in infinite polynomial ring #34535

trevorkarn opened this issue Sep 15, 2022 · 15 comments

Comments

@trevorkarn
Copy link
Contributor

sage: R.<z> = InfinitePolynomialRing(QQ)
sage: (z[4] + z[5])//(z[4] + z[5])
------------------------------------------------------------------------
(no backtrace available)
------------------------------------------------------------------------
Unhandled SIGSEGV: A segmentation fault occurred.
This probably occurred because a *compiled* module has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Python will now terminate.
------------------------------------------------------------------------
/Users/trevorkarn/Applications/sage/src/bin/sage-python: line 2: 49123 Segmentation fault: 11  sage -python "$@"

CC: @tscrim @trevorkarn

Component: algebra

Keywords: gsoc2022 infinite-polynomial divide

Author: Trevor K. Karn

Branch/Commit: 77cbf42

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34535

@trevorkarn trevorkarn added this to the sage-9.8 milestone Sep 15, 2022
@trevorkarn
Copy link
Contributor Author

New commits:

1f3e285Add _floordiv_

@trevorkarn
Copy link
Contributor Author

Branch: u/tkarn/divide-34535

@trevorkarn
Copy link
Contributor Author

Commit: 1f3e285

@tscrim
Copy link
Collaborator

tscrim commented Sep 15, 2022

comment:2

Do we need to implement checks for when the polynomials might not be in the same ring? Cf. _add_.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2022

Changed commit from 1f3e285 to 1f0a3d0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1f0a3d0Update floordiv

@trevorkarn
Copy link
Contributor Author

comment:4

Updated to be modeled after _add_.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2022

Changed commit from 1f0a3d0 to 77cbf42

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 17, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

77cbf42PEP8 compliance

@trevorkarn
Copy link
Contributor Author

comment:6

Ok things should now be good.

@tscrim
Copy link
Collaborator

tscrim commented Sep 18, 2022

comment:7

Green bot => positive review.

@trevorkarn
Copy link
Contributor Author

comment:8

There is one failure on the bot

**********************************************************************
File "src/sage/schemes/toric/sheaf/klyachko.py", line 951, in sage.schemes.toric.sheaf.klyachko.KlyachkoBundle_class.random_deformation
Failed example:
    Vtilde.cohomology(dim=True, weight=(0,))
Expected:
    (1, 0)
Got:
    (0, 0)
**********************************************************************

Which seems unrelated to this ticket.

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2022

comment:9

Indeed.

@tscrim
Copy link
Collaborator

tscrim commented Sep 19, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Sep 25, 2022

Changed branch from u/tkarn/divide-34535 to 77cbf42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants