Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage pexpect logs created during doctesting #34416

Closed
jhpalmieri opened this issue Aug 23, 2022 · 11 comments
Closed

Manage pexpect logs created during doctesting #34416

jhpalmieri opened this issue Aug 23, 2022 · 11 comments
Labels
c: doctest framework p: major / 3 t: bug
Milestone
sage-9.8

Comments

@jhpalmieri
Copy link
Member

The line

            sage: os.environ['SAGE_PEXPECT_LOG'] = "1"

which appears twice in sage/doctest/forker.py turns on logging for pexpect, and this results in two files being created in DOT_SAGE/pexpect_logs every time you doctest this file.

Doctests pass after deleting these lines, so let's remove those lines.

CC: @mkoeppe

Component: doctest framework

Author: John Palmieri

Branch/Commit: 543b665

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34416
@jhpalmieri jhpalmieri added this to the sage-9.7 milestone Aug 23, 2022
@jhpalmieri

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@jhpalmieri
Copy link
Member Author

Author: John Palmieri

@jhpalmieri

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/34416-do-not-create-pexpect-logs

@jhpalmieri
Copy link
Member Author

Commit: 543b665

@jhpalmieri
Copy link
Member Author

New commits:

543b665trac 34416: do not create pexpect logs when doctesting

@jhpalmieri
Copy link
Member Author

comment:6

I do not see any reason to create these logs.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

comment:8

I agree.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2022

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member Author

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 1, 2023

Changed branch from u/jhpalmieri/34416-do-not-create-pexpect-logs to 543b665

@vbraun vbraun closed this as completed in ebb9b61 Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe