Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'PosixPath' object has no attribute '_libgap_init_' #34111

Closed
mkoeppe opened this issue Jul 4, 2022 · 11 comments
Closed

'PosixPath' object has no attribute '_libgap_init_' #34111

mkoeppe opened this issue Jul 4, 2022 · 11 comments
Labels
c: group theory p: major / 3 t: bug
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 4, 2022

https://groups.google.com/g/sage-release/c/JZ5WOz2BNvA/m/GgIt-_3vAwAJ

probably from #33809

CC: @tscrim @fchapoton

Component: group theory

Author: Matthias Koeppe

Branch/Commit: 082864a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34111
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jul 4, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Branch: u/mkoeppe/posixpath__object_has_no_attribute___libgap_init_

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

Commit: 082864a

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2022

New commits:

082864aGap._element_constructor_: Convert Path objects to strings

@fchapoton
Copy link
Contributor

comment:3

duplicate of #34049

@tscrim
Copy link
Collaborator

tscrim commented Jul 4, 2022

comment:4

I would say it complements #34049 as it fixes a more underlying issue. So I would give this a positive review as well.

@fchapoton
Copy link
Contributor

comment:5

indeed, right

@tscrim
Copy link
Collaborator

tscrim commented Jul 4, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 4, 2022

comment:6

Then LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2022

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 9, 2022

Changed branch from u/mkoeppe/posixpath__object_has_no_attribute___libgap_init_ to 082864a

@vbraun vbraun closed this as completed in 65722f5 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: group theory p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@vbraun @tscrim @fchapoton @mkoeppe