Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage -t: Print git commit hash and SAGE_LOCAL, SAGE_VENV #33967

Closed
mkoeppe opened this issue Jun 9, 2022 · 11 comments
Closed

sage -t: Print git commit hash and SAGE_LOCAL, SAGE_VENV #33967

mkoeppe opened this issue Jun 9, 2022 · 11 comments
Labels
c: doctest framework p: major / 3 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 9, 2022

sage -t already prints the current branch. We add some more information so that the log files *test*.log become more useful.

Depends on #32937

CC: @jhpalmieri @kiwifb

Component: doctest framework

Author: Matthias Koeppe

Branch/Commit: f2468ab

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/33967
@mkoeppe mkoeppe added this to the sage-9.7 milestone Jun 9, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

Dependencies: #32937

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

Branch: u/mkoeppe/sage__t__print_git_commit_hash_and_sage_local__sage_venv

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

New commits:

4ae68ccfoo
d242f96src/sage/doctest/control.py: Show also 'git describe --always --dirty'
f2468absrc/sage/doctest/control.py: Show SAGE_LOCAL, SAGE_VENV

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

Commit: f2468ab

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2022

comment:4

Added #32937 as a dependency because this uses a Python 3.8 feature https://docs.python.org/3.10/whatsnew/3.8.html#f-strings-support-for-self-documenting-expressions-and-debugging

@jhpalmieri
Copy link
Member

comment:5

Looks okay to me. @kiwifb: okay from the distro point of view?

@kiwifb
Copy link
Member

kiwifb commented Jun 10, 2022

comment:6

It certainly looks OK to me. You can go ahead with a positive review.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 10, 2022

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Jun 12, 2022

Changed branch from u/mkoeppe/sage__t__print_git_commit_hash_and_sage_local__sage_venv to f2468ab

@vbraun vbraun closed this as completed in f793558 Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
4 participants
@kiwifb @vbraun @jhpalmieri @mkoeppe