-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer's guide: Expand on GitHub accounts and SSH keys #33700
Comments
This comment has been minimized.
This comment has been minimized.
Last 10 new commits:
|
Commit: |
comment:3
Let's get this in please. Only the last 3 commits need review, the earlier ones are all from #33648. |
comment:4
It looks good to me, but maybe it is worth keeping a note regarding the non-github login that uses the legacy account, after deleting the following.
|
comment:5
I deleted it because this information is also on the front page of Trac (https://trac.sagemath.org/#legacy-account-request). I've just edited https://wiki.sagemath.org/#About_this_wiki to also be clearer about this. The big problem with mentioning the legacy account requests is that no one actually tends to them. (I requested one in January for a special purpose and have not received a reply.) |
comment:6
I didn't make it clear. Actually I was wondering if you could add a note in the guide, saying that the first login button on the trac page is only for legacy account users; and that if the user had such an account, then the login instead of github-login is the right one to use. (If I haven't used trac for a while and I got a new laptop that does not have my Username/Password cached, then I will be confused about the trac page's login/github-login, and I won't find the instruction in the new developer's guide.) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
OK, done. I've also edited the top of https://trac.sagemath.org/ to make this clearer. |
Reviewer: Yuan Zhou |
comment:9
Great! Thank you for editing the top of trac page. I find it very helpful. |
comment:10
Thanks for the review! |
comment:12
docbuild fails |
comment:13
Can't reproduce an error here on top of vbraun/develop, 7950f93 |
Changed branch from u/mkoeppe/developer_s_guide__expand_on_github_accounts_and_ssh_keys to |
(split out from #33687)
We move the section on creating SSH keys from the section on Trac to a later section, as creating tickets and participating in discussions on tickets does not require SSH keys.
This is also preparation for #33687 (gitlab workflow).
Depends on #33648
CC: @slel @dimpase @tobiasdiez @sagetrac-tmonteil @yuan-zhou
Component: documentation
Author: Matthias Koeppe
Branch/Commit:
4c03af3
Reviewer: Yuan Zhou
Issue created by migration from https://trac.sagemath.org/ticket/33700
The text was updated successfully, but these errors were encountered: