Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycodestyle cleaning in discrete Fourier transforms #33324

Closed
fchapoton opened this issue Feb 11, 2022 · 13 comments
Closed

pycodestyle cleaning in discrete Fourier transforms #33324

fchapoton opened this issue Feb 11, 2022 · 13 comments
Labels
c: calculus p: major / 3 t: enhancement
Milestone
sage-9.6

Comments

@fchapoton
Copy link
Contributor

also fixing bugs in discrete Sine and Cosine transforms

CC: @tscrim @slel @kliem

Component: calculus

Author: Frédéric Chapoton

Branch/Commit: 93cc7c0

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33324
@fchapoton fchapoton added this to the sage-9.6 milestone Feb 11, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33324

@fchapoton
Copy link
Contributor Author

New commits:

38888e0pep8 of discrete Fourier transforms

@fchapoton
Copy link
Contributor Author

Commit: 38888e0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 11, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1603529fix doctests + Daubechies

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 11, 2022

Changed commit from 38888e0 to 1603529

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor Author

comment:3

green bot, so please review

@tscrim
Copy link
Collaborator

tscrim commented Feb 12, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 12, 2022

comment:4

LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 13, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

93cc7c0Merge branch 'u/chapoton/33324' in 9.6.b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 13, 2022

Changed commit from 1603529 to 93cc7c0

@fchapoton
Copy link
Contributor Author

comment:6

set back to positive after trivial rebase

@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Changed branch from u/chapoton/33324 to 93cc7c0

@vbraun vbraun closed this as completed in 44cd8f8 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: calculus p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton