Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for build/pkgs/tox/distros/gentoo.txt #33269

Closed
sheerluck opened this issue Feb 1, 2022 · 14 comments
Closed

fix for build/pkgs/tox/distros/gentoo.txt #33269

sheerluck opened this issue Feb 1, 2022 · 14 comments

Comments

@sheerluck
Copy link
Contributor

The short ebuild name "tox" is ambiguous.
What we need is dev-python/tox:

$ cat build/pkgs/tox/distros/gentoo.txt
dev-python/tox

CC: @slel @kiwifb @strogdon

Component: docker

Author: Andrey Belgorodski, Samuel Lelièvre

Branch/Commit: 14dada9

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/33269

@sheerluck sheerluck added this to the sage-9.6 milestone Feb 1, 2022
@slel
Copy link
Member

slel commented Feb 1, 2022

Author: Samuel Lelièvre

@slel
Copy link
Member

slel commented Feb 1, 2022

Commit: 06efee0

@slel
Copy link
Member

slel commented Feb 1, 2022

Branch: u/slelievre/33269

@slel
Copy link
Member

slel commented Feb 1, 2022

comment:1

Here's a branch doing that.

Taking the opportunity to remove tox distro info
for Cygwin, as tox is not packaged in Cygwin.


New commits:

06efee033269: Fix tox distro info

@slel
Copy link
Member

slel commented Feb 1, 2022

Changed author from Samuel Lelièvre to Andrey Belgorodski, Samuel Lelièvre

@sheerluck
Copy link
Contributor Author

comment:3

Thank you!

@sheerluck
Copy link
Contributor Author

comment:4

I wish that François Bissey would visited this ticket and gave it positive review :)

@slel
Copy link
Member

slel commented Feb 1, 2022

comment:5

Cc-ing Gentoo packagers.

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

comment:6

Yes, this is needed, tox by itself is ambiguous on Gentoo.

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

Reviewer: François Bissey

@slel
Copy link
Member

slel commented Feb 2, 2022

comment:7

With correct authorship.


New commits:

b08400133269: Fix build/pkgs/tox/distros/gentoo.txt
14dada933269: Remove tox Cygwin package name

@slel
Copy link
Member

slel commented Feb 2, 2022

Changed branch from u/slelievre/33269 to public/33269

@slel
Copy link
Member

slel commented Feb 2, 2022

Changed commit from 06efee0 to 14dada9

@vbraun
Copy link
Member

vbraun commented Feb 12, 2022

Changed branch from public/33269 to 14dada9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants