Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxWarning when byte-compiling sagetexparse.py #33128

Closed
tornaria opened this issue Jan 7, 2022 · 10 comments
Closed

SyntaxWarning when byte-compiling sagetexparse.py #33128

tornaria opened this issue Jan 7, 2022 · 10 comments
Labels
c: packages: standard r: invalid t: bug

Comments

@tornaria
Copy link
Contributor

tornaria commented Jan 7, 2022 

.../share/texmf/tex/latex/sagetex/sagetexparse.py:135: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if t.format is not '':

This is already fixed upstream.

Depends on #32887

CC: @dimpase

Component: packages: standard

Branch/Commit: u/tornaria/sagetex-fix-warning @ 53e4d68

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33128
@tornaria tornaria added this to the sage-9.5 milestone Jan 7, 2022
@tornaria
Copy link
Contributor Author

tornaria commented Jan 7, 2022

New commits:

53e4d68sagetex: Fix a warning when byte-compiling sagetexparse.py

@tornaria
Copy link
Contributor Author

tornaria commented Jan 7, 2022

Author: Gonzalo Tornaría

@tornaria
Copy link
Contributor Author

tornaria commented Jan 7, 2022

Branch: u/tornaria/sagetex-fix-warning

@tornaria
Copy link
Contributor Author

tornaria commented Jan 7, 2022

Commit: 53e4d68

@dimpase
Copy link
Member

dimpase commented Jan 7, 2022

comment:3

we should rather go ahead with updating sagetex to 3.6.

I hope to be able to have a look at it again next week.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 28, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 26, 2022

Dependencies: #32887

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 26, 2022

comment:7

I think this outdated after the update done in #32887.

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 26, 2022

Changed author from Gonzalo Tornaría to none

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Sep 26, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Oct 14, 2022

Reviewer: Kwankyu Lee

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 14, 2022

comment:8

Yes. It's already fixed.

@mkoeppe mkoeppe closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard r: invalid t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dimpase @kwankyu @tornaria @mkoeppe