Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run bootstrap when an install-requires.txt or package-version.txt has changed #33115

Closed
mkoeppe opened this issue Jan 4, 2022 · 7 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 4, 2022

Developers may see messages like the following when merging package upgrade tickets such as #32968.

Installing collected packages: Sphinx
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-apidoc to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-autogen to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-build to 755
  changing mode of /home/gitpod/sage-local/var/lib/sage/venv-python3.8/bin/sphinx-quickstart to 755
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
sagemath-standard 9.5b9 requires sphinx<4.3,>=4, but you have sphinx 4.3.1 which is incompatible.
Successfully installed Sphinx-4.3.1

bootstrap generates various files (in the above, src/install-requires.txt) from the source files build/pkgs/*/install-requires.txt).
To fix this, we should add these files as dependencies of the configure target in the top-level Makefile.

Likewise for the source files build/pkgs/*/package-version.txt, which influence other files such as src/requirements.txt that are generated by bootstrap.

Component: build

Author: Matthias Koeppe

Branch/Commit: 686fa78

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33115

@mkoeppe mkoeppe added this to the sage-9.5 milestone Jan 4, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 4, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 4, 2022

New commits:

686fa78Makefile (configure): Add dependencies on install-requires.txt and package-version.txt

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 4, 2022

Commit: 686fa78

@mkoeppe mkoeppe changed the title Re-run bootstrap when an install-requires.txt has changed Re-run bootstrap when an install-requires.txt or package-version.txt has changed Jan 4, 2022
@orlitzky
Copy link
Contributor

orlitzky commented Jan 5, 2022

Reviewer: Michael Orlitzky

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 5, 2022

comment:4

Thank you!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@vbraun
Copy link
Member

vbraun commented Feb 16, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants