Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random doctest failure in src/sage/crypto/util.py #33036

Closed
yyyyx4 opened this issue Dec 17, 2021 · 7 comments
Closed

random doctest failure in src/sage/crypto/util.py #33036

yyyyx4 opened this issue Dec 17, 2021 · 7 comments
Labels
c: cryptography p: minor / 4 t: bug
Milestone
sage-9.5

Comments

@yyyyx4
Copy link
Member

yyyyx4 commented Dec 17, 2021

Part of #32544:

sage -t --long --random-seed=88125173308017227407627450515947596866 src/sage/crypto/util.py
**********************************************************************
File "src/sage/crypto/util.py", line 359, in sage.crypto.util.carmichael_lambda
Failed example:
    P == ones
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of  32 in sage.crypto.util.carmichael_lambda
    [113 tests, 1 failure, 0.07 s]

(From a doctest in #32502.)

Component: cryptography

Author: Lorenz Panny

Branch/Commit: 12e678a

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33036
@yyyyx4 yyyyx4 added this to the sage-9.5 milestone Dec 17, 2021
@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 17, 2021

Commit: 12e678a

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 17, 2021

Branch: public/33036

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 17, 2021

Author: Lorenz Panny

@orlitzky
Copy link
Contributor

Reviewer: Michael Orlitzky

@orlitzky
Copy link
Contributor

comment:2

LGTM, presumably working mod-1 messes things up?

@yyyyx4
Copy link
Member Author

yyyyx4 commented Dec 21, 2021

comment:3

Exactly, the test does something along the lines of [power_mod(...,n) for ...] == [1,1,1,...] which fails for n==1 because the left side is all zeroes.

@vbraun
Copy link
Member

vbraun commented Jan 1, 2022

Changed branch from public/33036 to 12e678a

@vbraun vbraun closed this as completed in 283fef8 Jan 1, 2022
@kliem kliem mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cryptography p: minor / 4 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @orlitzky @yyyyx4