Put SAGE_ROOT/src/bin in PATH only when invoked by SAGE_ROOT/sage or sage-build-env

[mkoeppe]

Only when invoked as SAGE_ROOT/sage or SAGE_ROOT/src/bin/sage, then $SAGE_ROOT/src/bin should be put in the front of PATH.

When the installed sage script, SAGE_VENV/bin/sage, is invoked directly, it should not put $SAGE_ROOT/src/bin on the PATH.

CC: @kwankyu @jhpalmieri

Component: scripts

Author: Matthias Koeppe

Branch/Commit: 7519048

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/32933

[mkoeppe]

Branch: u/mkoeppe/put_sage_root_src_bin_in_path_only_when_invoked_by_sage_root_sage_or_sage_build_env

[mkoeppe]

New commits:

7519048

src/bin/sage[-env]: Put SAGE_ROOT/src/bin in front of path only if run out of this directory

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 7519048

[jhpalmieri]

comment:3

Is this supposed to solve a particular problem, or is it general cleanup?

[mkoeppe]

comment:4

It fixes a problem when sagemath-standard is installed in a user-defined venv. In this case, before this ticket, the installed sage script would actually end up running sage from SAGE_ROOT/venv.

We ran into this in #29865. The distribution sagemath-objects, as of #29865, also installs the sage script, and it had this behavior.

[kwankyu]

comment:5

Replying to @mkoeppe:

We ran into this in #29865. The distribution sagemath-objects, as of #29865, also installs the sage script, and it had this behavior.

As this is merged with #29865, we can set the status when we do so for #29865. Is this okay?

[mkoeppe]

comment:6

That's fine, but the idea with opening this separate ticket was that it can be reviewed separately.

[kwankyu]

comment:7

Replying to @mkoeppe:

That's fine, but the idea with opening this separate ticket was that it can be reviewed separately.

Of course, it is okay that someone else, perhaps John, reviews this, earlier than #29865.

[kwankyu]

comment:8

Already merged with #29865

[mkoeppe]

comment:9

It's better to merge it, so that the ticket description is included in the commit message.

[mkoeppe]

Reviewer: Kwankyu Lee

[vbraun]

Changed branch from u/mkoeppe/put_sage_root_src_bin_in_path_only_when_invoked_by_sage_root_sage_or_sage_build_env to 7519048