Update singular to 4.2.1p3 #32907

mkoeppe · 2021-11-19T18:21:34Z

From the release notes: update for using FLINT 2.8.x

The FLINT/Singular problem on ubuntu-trusty
will be fixed by this (already merged)
pull request to FLINT:

flint.h: On GCC < 4.9, do not use _Thread_local flintlib/flint#1040

CC: @dimpase @orlitzky @kiwifb @antonio-rojas @slel

Component: packages: standard

Keywords: upgrade, Singular

Author: Matthias Koeppe, Antonio Rojas

Branch: 0856554

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32907

The text was updated successfully, but these errors were encountered:

mkoeppe · 2021-11-19T18:23:12Z

Branch: u/mkoeppe/update_singular_to_4_2_1p2

mkoeppe · 2021-11-19T18:40:58Z

Author: Matthias Koeppe

mkoeppe · 2021-11-19T18:40:58Z

Commit: 4cf59d3

mkoeppe · 2021-11-19T18:40:58Z

New commits:

`4cf59d3`	`build/pkgs/singular: Update to 4.2.1p2`

sagetrac-git · 2021-11-19T18:44:39Z

Changed commit from 4cf59d3 to 5b2d003

sagetrac-git · 2021-11-19T18:44:39Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5b2d003`	`build/pkgs/singular: Remove patch`

mkoeppe · 2021-11-19T18:54:46Z

comment:4

Build ends with Error: source file/directory doc/singular.idx does not exist

sagetrac-git · 2021-11-19T19:57:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`26a7332`	`build/pkgs/singular/spkg-install.in: Remove workaround for singular.idx, it is now in doc.tbz2`

sagetrac-git · 2021-11-19T19:57:00Z

Changed commit from 5b2d003 to 26a7332

orlitzky · 2021-11-19T20:40:56Z

comment:7

Passing -j1 to "make" should no longer be necessary.

sagetrac-git · 2021-11-19T20:45:04Z

Changed commit from 26a7332 to bb1f741

sagetrac-git · 2021-11-19T20:45:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bb1f741`	`build/pkgs/singular/spkg-install.in: Remove workaround for make paralellization bugs`

mkoeppe · 2021-11-19T20:51:47Z

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1482688821, https://github.com/mkoeppe/sage/actions/runs/1482688827

mkoeppe · 2021-11-20T00:09:12Z

comment:12

This gives errors in the sagelib build:

  [sagelib-9.5.beta7]   build/cythonized/sage/rings/polynomial/multi_polynomial_libsingular.cpp:33693:18: note: in expansion of macro ‘p_SetCoeff0’
  [sagelib-9.5.beta7]              (void)(p_SetCoeff0(__pyx_v_temp, n_Copy(p_GetCoeff(__pyx_v_p, __pyx_v_r), __pyx_v_r), __pyx_v_r));
  [sagelib-9.5.beta7]                     ^
  [sagelib-9.5.beta7]   build/cythonized/sage/rings/polynomial/multi_polynomial_libsingular.cpp: In function ‘PyObject* __pyx_pf_4sage_5rings_10polynomial_28multi_polynomial_libsingular_23MPolynomial_libsingular_104factor(__pyx_obj_4sage_5rings_10polynomial_28multi_polynomial_libsingular_MPolynomial_libsingular*, PyObject*)’:
  [sagelib-9.5.beta7]   build/cythonized/sage/rings/polynomial/multi_polynomial_libsingular.cpp:34874:40: error: cannot convert ‘ip_sring*’ to ‘coeffs {aka n_Procs_s*}’ for argument ‘1’ to ‘int n_GetChar(coeffs)’
  [sagelib-9.5.beta7]      __pyx_t_7 = ((n_GetChar(__pyx_v__ring) > 0x20000000) != 0);
  [sagelib-9.5.beta7]                                           ^

mkoeppe · 2021-11-20T02:52:47Z

Changed author from Matthias Koeppe to Matthias Koeppe, ...

antonio-rojas · 2021-11-20T10:31:35Z

Changed branch from u/mkoeppe/update_singular_to_4_2_1p2 to u/arojas/update_singular_to_4_2_1p2

sagetrac-git · 2021-11-20T11:41:51Z

Changed commit from bb1f741 to 720d10e

sagetrac-git · 2021-11-20T11:41:51Z

Branch pushed to git repo; I updated commit sha1. New commits:

`720d10e`	`Update tests for singular 4.2.1p2`

antonio-rojas · 2021-11-20T11:47:06Z

comment:18

Builds now, also with older singular (at least as far back as 4.2.0p1). I've also tried to keep tests compatible with older singular, except for the example in rings/polynomial/hilbert.pyx, which failed before and works now. Should we care about it?

antonio-rojas · 2021-11-20T11:47:06Z

Changed author from Matthias Koeppe, ... to Matthias Koeppe, Antonio Rojas

slel · 2021-11-26T22:58:04Z

comment:37

If it helps I could try this ticket out
on a few machines (Cygwin, Linux, macOS).

For now I can only offer trivial comments
(feel free to disregard them).

I would wrap this long output line:

         sage: J.hilbert_numerator(algorithm='singular')
-        120*t^33 - 3465*t^32 + 48180*t^31 - 429374*t^30 + 2753520*t^29 - 13522410*t^28 + 52832780*t^27 - 168384150*t^26 + 445188744*t^25 - 987193350*t^24 + 1847488500*t^23 + 1372406746*t^22 - 403422496*t^21 - 8403314*t^20 - 471656596*t^19 + 1806623746*t^18 + 752776200*t^17 + 752776200*t^16 - 1580830020*t^15 + 1673936550*t^14 - 1294246800*t^13 + 786893250*t^12 - 382391100*t^11 + 146679390*t^10 - 42299400*t^9 + 7837830*t^8 - 172260*t^7 - 468930*t^6 + 183744*t^5 - 39270*t^4 + 5060*t^3 - 330*t^2 + 1
+        120*t^33 - 3465*t^32 + 48180*t^31 - 429374*t^30 + 2753520*t^29
+        - 13522410*t^28 + 52832780*t^27 - 168384150*t^26 + 445188744*t^25
+        - 987193350*t^24 + 1847488500*t^23 + 1372406746*t^22 - 403422496*t^21
+        - 8403314*t^20 - 471656596*t^19 + 1806623746*t^18 + 752776200*t^17
+        + 752776200*t^16 - 1580830020*t^15 + 1673936550*t^14 - 1294246800*t^13
+        + 786893250*t^12 - 382391100*t^11 + 146679390*t^10 - 42299400*t^9
+        + 7837830*t^8 - 172260*t^7 - 468930*t^6 + 183744*t^5 - 39270*t^4
+        + 5060*t^3 - 330*t^2 + 1

or maybe even rewrite that doctest as:

-        sage: J.hilbert_numerator(algorithm='singular')
+        sage: p = J.hilbert_numerator(algorithm='singular')
+        sage: p.list()
+        [1, 0, -330, 5060, -39270, 183744, -468930, -172260, 7837830,
+         -42299400, 146679390, -382391100, 786893250, -1294246800,
+         1673936550, -1580830020, 752776200, 752776200, 1806623746,
+         -471656596, -8403314, -403422496, 1372406746, 1847488500,
+         -987193350, 445188744, -168384150, 52832780, -13522410,
+         2753520, -429374, 48180, -3465, 120]

whose output I personally find easier to parse visually.

Another wrapping suggestion:

-        [x + y + 57119*z + 4, y^2 + 3*y + 17220, y*z + ..., 2*y + 158864, z^2 + 17223, 2*z + 41856, 164878]
+        [x + y + 57119*z + 4, y^2 + 3*y + 17220, y*z + ...,
+         2*y + 158864, z^2 + 17223, 2*z + 41856, 164878]

Some pep8 whitespace suggestions (the last two occur several times):

-            n_Delete(&n,r.cf)
+            n_Delete(&n, r.cf)

-                p_SetCoeff(newptemp,n_Copy(p_GetCoeff(p,r),r.cf),r)
+                p_SetCoeff(newptemp, n_Copy(p_GetCoeff(p, r), r.cf), r)

-            p_SetCoeff(p, n_Init(1,_ring.cf), _ring)
+            p_SetCoeff(p, n_Init(1, _ring.cf), _ring)

slel · 2021-11-26T22:58:04Z

Changed keywords from none to upgrade, Singular

mkoeppe · 2021-11-26T23:04:19Z

comment:38

Cygwin testing would be valuable

mkoeppe · 2021-11-27T19:49:21Z

comment:39

Also please feel free to push these edits to the ticket

mkoeppe · 2021-12-09T21:15:37Z

comment:40

Setting to blocker because system singular is already being picked up by our spkg-configure

mkoeppe · 2021-12-17T23:29:58Z

comment:41

Let's get this in please

antonio-rojas · 2021-12-17T23:39:00Z

comment:42

4.2.1p3 is out including the commit needed for #32959

dimpase · 2021-12-18T00:08:02Z

comment:43

yes, seems like a nice update to get: https://github.com/Singular/Singular/releases/tag/Release-4-2-1p3

sagetrac-git · 2021-12-18T04:20:14Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a137b7e`	`Merge tag '9.5.beta8' into t/32907/update_singular_to_4_2_1p2`
`0856554`	`build/pkgs/singular: Update to 4.2.1p3`

sagetrac-git · 2021-12-18T04:20:14Z

Changed commit from eea6328 to 0856554

mkoeppe · 2021-12-18T04:21:22Z

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1485019210, https://github.com/mkoeppe/sage/actions/runs/1485019208 to none

mkoeppe · 2021-12-18T18:49:18Z

comment:46

Tests on GH Actions look fine.

mkoeppe · 2021-12-18T18:49:18Z

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1595134485

dimpase · 2021-12-22T23:59:52Z

comment:47

lgtm

dimpase · 2021-12-22T23:59:52Z

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1595134485 to Dima Pasechnik

mkoeppe · 2021-12-23T00:17:56Z

comment:48

Thanks!

vbraun · 2021-12-28T21:15:55Z

Changed branch from u/mkoeppe/update_singular_to_4_2_1p2 to 0856554

dimpase · 2022-01-13T13:34:50Z

comment:50

update to 4.3.0 is dealt with on #33160

dimpase · 2022-01-13T13:34:50Z

Changed commit from 0856554 to none

mkoeppe added this to the sage-9.5 milestone Nov 19, 2021

mkoeppe added c: packages: standard labels Nov 19, 2021

mkoeppe added the s: needs review label Nov 19, 2021

This comment has been minimized.

Sign in to view

mkoeppe added s: needs work and removed s: needs review labels Nov 20, 2021

antonio-rojas added s: needs review and removed s: needs work labels Nov 20, 2021

This comment has been minimized.

Sign in to view

mkoeppe added p: blocker / 1 and removed p: major / 3 labels Dec 9, 2021

mkoeppe changed the title ~~Update singular to 4.2.1p2~~ Update singular to 4.2.1p3 Dec 18, 2021

dimpase added s: positive review and removed s: needs review labels Dec 22, 2021

vbraun removed the s: positive review label Dec 28, 2021

vbraun closed this as completed in 2f51044 Dec 28, 2021

dimpase mentioned this issue Jan 6, 2023

Meta-ticket: Remove support for outdated distros #32074

Open

kliem mentioned this issue Jan 31, 2022

Unstable doctest in hmm/chmm.pyx #32890

Closed

dimpase mentioned this issue Oct 21, 2022

update Singular to 4.3.1 #33160

Closed

Update singular to 4.2.1p3 #32907

Update singular to 4.2.1p3 #32907

Comments

mkoeppe commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

orlitzky commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

sagetrac-git mannequin commented Nov 19, 2021

mkoeppe commented Nov 19, 2021

This comment has been minimized.

mkoeppe commented Nov 20, 2021

mkoeppe commented Nov 20, 2021

antonio-rojas commented Nov 20, 2021

sagetrac-git mannequin commented Nov 20, 2021

sagetrac-git mannequin commented Nov 20, 2021

antonio-rojas commented Nov 20, 2021

antonio-rojas commented Nov 20, 2021

slel commented Nov 26, 2021

slel commented Nov 26, 2021

This comment has been minimized.

mkoeppe commented Nov 26, 2021

mkoeppe commented Nov 27, 2021

mkoeppe commented Dec 9, 2021

mkoeppe commented Dec 17, 2021

antonio-rojas commented Dec 17, 2021

dimpase commented Dec 18, 2021

sagetrac-git mannequin commented Dec 18, 2021

sagetrac-git mannequin commented Dec 18, 2021

mkoeppe commented Dec 18, 2021

mkoeppe commented Dec 18, 2021

mkoeppe commented Dec 18, 2021

dimpase commented Dec 22, 2021

dimpase commented Dec 22, 2021

mkoeppe commented Dec 23, 2021

vbraun commented Dec 28, 2021

dimpase commented Jan 13, 2022

dimpase commented Jan 13, 2022