Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Singular example with GAP in _get_shared_lib_path() #32880

Closed
orlitzky opened this issue Nov 16, 2021 · 8 comments
Closed

Replace Singular example with GAP in _get_shared_lib_path() #32880

orlitzky opened this issue Nov 16, 2021 · 8 comments

Comments

@orlitzky
Copy link
Contributor

We still have a doctest for _get_shared_lib_path() that ensures it can find libSingular. However,

  1. the premise behind _get_shared_lib_path() does not make sense; you can't just guess where a library comes from
  2. as a result of (1), it's failing to find libSingular in some cases; but thankfully
  3. we no longer care if it can find libSingular, because the full path to libSingular is contained in LIBSINGULAR_PATH

Instead we should have it look for libgap, because gap is still installed from an SPKG, and we can ensure that it's installed in just the right way for _get_shared_lib_path() to find it. Moreover, we actually call the function with "gap" as an argument, so there's that.

Reported in #29024 comment:168

Component: misc

Author: Michael Orlitzky

Branch/Commit: 17e308f

Reviewer: Gonzalo Tornaría

Issue created by migration from https://trac.sagemath.org/ticket/32880

@orlitzky orlitzky added this to the sage-9.5 milestone Nov 16, 2021
@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@orlitzky
Copy link
Contributor Author

New commits:

17e308fTrac #32880: use GAP instead of Singular to test _get_shared_lib_path().

@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/32880

@orlitzky
Copy link
Contributor Author

Commit: 17e308f

@tornaria
Copy link
Contributor

comment:3

Looks good to me. I took the patch for the sagemath package for void linux (wip) which uses system singular, and the failing doctest now passes.

See ​void-linux/void-packages#34030

@tornaria
Copy link
Contributor

Reviewer: Gonzalo Tornaría

@vbraun
Copy link
Member

vbraun commented Dec 19, 2021

Changed branch from u/mjo/ticket/32880 to 17e308f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants