-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Singular example with GAP in _get_shared_lib_path() #32880
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Author: Michael Orlitzky |
New commits:
|
Branch: u/mjo/ticket/32880 |
Commit: |
comment:3
Looks good to me. I took the patch for the sagemath package for void linux (wip) which uses system singular, and the failing doctest now passes. |
Reviewer: Gonzalo Tornaría |
Changed branch from u/mjo/ticket/32880 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We still have a doctest for
_get_shared_lib_path()
that ensures it can find libSingular. However,_get_shared_lib_path()
does not make sense; you can't just guess where a library comes fromLIBSINGULAR_PATH
Instead we should have it look for libgap, because gap is still installed from an SPKG, and we can ensure that it's installed in just the right way for
_get_shared_lib_path()
to find it. Moreover, we actually call the function with "gap" as an argument, so there's that.Reported in #29024 comment:168
Component: misc
Author: Michael Orlitzky
Branch/Commit:
17e308f
Reviewer: Gonzalo Tornaría
Issue created by migration from https://trac.sagemath.org/ticket/32880
The text was updated successfully, but these errors were encountered: