-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyzmq: Fix build errors; zeromq, pyzmq: Update; setuptools: upgrade to 59.2.0 #32828
Comments
comment:3
weird. |
comment:4
I'd have tried updating zeromq to the latest version, 4.3.4. |
comment:5
Replying to @dimpase:
It didn't work for me. I tried also to use pyzmq-22.3.0; it fails to download https://github.com/zeromq/libzmq/releases/download/v4.3.4/zeromq-4.3.4.zip and stops (downloading directly works) Compiling pyzmq outside Sage gives no error; maybe some local variable? Is is possible to use system package? |
comment:6
I think the attempted configuration with This is another case where the locations discovered by the configure tests in |
comment:7
Sorry, but the error happens in the minimal build, spkg-configure.m4 is not involved, right? |
comment:8
You are right, it isn't; I should have written "this is also another case..." |
comment:9
Is there a temptative solution to test? Replying to @mkoeppe:
|
comment:10
Dirty trick to test the other changes in Fedora 35:
and comment out the install line in I am running tests now. |
comment:11
I finished two compilations in Fedora 35, in both cases using a package of cysignals from https://github.com/enriqueartal/cysignals/commit/b404fbef69ddd5cfd0085ab15885e9f0315f9471 which is actually https://github.com/kliem/cysignals/tree/fix_non_constant_MINSIGSTKSZ up to a right parenthesis and installing pymzq as in comment:10. One compilation is for 9.4. The test gave the following failures:
Some of them seem to be harmless (right permissions), other ones may reflect some problems between giac and cysignals. The second one is for the branch #30766 merged with develop, with the above cysignals and pyzmq and also gmpy2-2.1.0rc1. Besides the errors below, I did not find jupyter in
|
comment:12
I think the above would be better to discuss in #30767. |
comment:13
It looks like |
comment:15
Replying to @mkoeppe:
The recent |
Branch: u/mkoeppe/pyzmq__build_errors |
Commit: |
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:28
Replying to @enriqueartal:
This is the bug that I fixed in |
comment:29
I made a clean install (including cffi) and modifying cysignals, and it works the compilation, I am testing now. Sorry for the noise. |
comment:30
These are the non successful tests:
This is the result with Python3-3.10 package (with system package there were plenty of segmentation faults, also with the package and testpy installed). I hope it helps. |
comment:31
Thanks for testing. So for this ticket - installation was successful. The test failures are surely unrelated to setuptools and pyzmq. Let's get this fix in then. |
Upstream: Fixed upstream, but not in a stable release. |
comment:32
pypa/distutils#65 has been merged |
comment:33
... and is included in https://setuptools.pypa.io/en/latest/history.html#v59-0-0 (not yet on PyPI) |
comment:34
setuptools 59.0.1 is out, but it looks like we should wait for 59.1.0 so that we can avoid the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release. |
This comment has been minimized.
This comment has been minimized.
comment:38
Let's get this in please |
This comment has been minimized.
This comment has been minimized.
Reviewer: Dima Pasechnik |
comment:42
lgtm |
comment:43
Thanks! |
comment:44
Works for me on void linux using musl libc which used to fail (I was carrying a different patch before; I've replaced that patch by the changes in this ticket and it works). |
comment:45
Thanks for testing! |
Changed branch from u/mkoeppe/pyzmq__build_errors to |
Changed commit from |
pyzmq
fails to build on some platforms. We fix it bysetuptools
to a version that includes CCompiler.has_function: Do not fail if self.outputdir is set pypa/distutils#65pyzmq
build configurationWe also upgrade
pyzmq
andzeromq
to the latest versions.For example on
opensuse-tumbleweed-minimal
(https://github.com/mkoeppe/sage/runs/4085305194?check_suite_focus=true)Also reported in #31855 comment:22
Upstream: Fixed upstream, in a later stable release.
CC: @enriqueartal @jhpalmieri @dimpase
Component: packages: standard
Author: Matthias Koeppe
Branch:
b430bcf
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32828
The text was updated successfully, but these errors were encountered: