Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.geometry.polyhedron.backend_cdd: Go through sage.features for _cdd_executable #32645

Closed
mkoeppe opened this issue Oct 6, 2021 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 6, 2021

This is so that the Sage library becomes fully functional even when not being run from within sage-env (which sets PATH).

To test (when cddlib is not present in the system but installed as SPKG):

venv/bin/python3 -c 'from sage.all import *; print(Polyhedron(vertices=[[1.123456789012345, 2.123456789012345]], base_ring=RDF))'

Depends on #31296

CC: @kliem @saraedum

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 14d3a65

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32645

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 6, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 5, 2022

Dependencies: #31296

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2022

Last 10 new commits:

a93e9afsrc/sage/features/__init__.py: Simplify Executable.absolute_path
5b25c1dsage.features: Refactor StaticFile, Executable through a new base class FileFeature
6c35717sage.features.FileFeature: Replace method absolute_path by absolute_filename, with deprecation
9266709Merge #31292
a4d0ed6sage.interfaces.four_ti_2: Use Executable.absolute_filename
4252ea3sage.sandpiles.sandpile: Use Executable.absolute_filename() when interfacing 4ti2
17b9fdesage.interfaces.latte: Use Executable.absolute_filename
777e643Merge #31296
bbb6c1fsage.features.cddlib: New
14d3a65sage.geometry.polyhedron.backend_cdd: Use CddExecutable(...).absolute_filename()

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2022

Commit: 14d3a65

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2022

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2022

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Mar 7, 2022

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 7, 2022

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants