Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark unstable tests due to #29956 #32543

Closed
kliem opened this issue Sep 21, 2021 · 10 comments
Closed

Mark unstable tests due to #29956 #32543

kliem opened this issue Sep 21, 2021 · 10 comments
Labels
c: algebraic geometry p: major / 3 t: enhancement
Milestone
sage-9.5

Comments

@kliem
Copy link
Contributor

kliem commented Sep 21, 2021

This ticket has been merged by #29956.

However, #29956 did not mention it as a dependency, so only the commit was merged and the ticket was left open.

CC: @vbraun

Component: algebraic geometry

Author: Jonathan Kliem

Reviewer: David Ayotte

Issue created by migration from https://trac.sagemath.org/ticket/32543
@kliem kliem added this to the sage-9.5 milestone Sep 21, 2021
@kliem
Copy link
Contributor Author

kliem commented Sep 21, 2021

comment:2

The failures not already marked as not tested can be reproduced with

sage -t --long --random-seed=278359527985830794615851381295249030671 src/sage/schemes/toric/sheaf/klyachko.py  # 3 doctests failed

@DavidAyotte
Copy link
Member

comment:3

Green bot and everything looks good.

@kliem
Copy link
Contributor Author

kliem commented Sep 22, 2021

comment:4

Thank you.

@fchapoton
Copy link
Contributor

comment:5

missing reviewer full name, please

@fchapoton
Copy link
Contributor

Reviewer: David Ayotte

@mkoeppe mkoeppe changed the title Mark unstable tests due do #29956 Mark unstable tests due to #29956 Sep 22, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 14, 2021

comment:8

This ticket seems to be ignored by Volker's merging script

@kliem
Copy link
Contributor Author

kliem commented Nov 14, 2021

comment:9

That's because I messed up on #29956.

This ticket here should have been a dependency of #29956. It's only commit is part of #29956.

So move this to duplicate/won't fix?

@mkoeppe mkoeppe removed this from the sage-9.5 milestone Nov 14, 2021
@kliem

This comment has been minimized.

Sign in to view
@kliem
Copy link
Contributor Author

kliem commented Nov 15, 2021

Changed branch from u/gh-kliem/mark_doctests_for_29956 to none

@kliem
Copy link
Contributor Author

kliem commented Nov 15, 2021

Changed commit from 0828599 to none

@mkoeppe mkoeppe closed this as completed Nov 15, 2021
@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 15, 2021
This was referenced Oct 9, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
4 participants
@fchapoton @mkoeppe @kliem @DavidAyotte