Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary uses of symbolic functions in sage.tensor.modules #32415

Closed
mkoeppe opened this issue Aug 24, 2021 · 11 comments
Closed

Remove unnecessary uses of symbolic functions in sage.tensor.modules #32415

mkoeppe opened this issue Aug 24, 2021 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 24, 2021

Similar to what is done in #32411.

This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution sagemath-symbolics (#31695)

CC: @egourgoulhon @mjungmath @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: ac82dd2

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/32415
@mkoeppe mkoeppe added this to the sage-9.5 milestone Aug 24, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

Branch: u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

Commit: ac82dd2

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 24, 2021

New commits:

ac82dd2sage.tensor.modules: Remove unnecessary uses of symbolic functions

@mkoeppe mkoeppe changed the title Remove unnecessary uses of SR and symbolic functions in sage.tensor.modules Remove unnecessary uses of symbolic functions in sage.tensor.modules Aug 24, 2021
@egourgoulhon
Copy link
Member

comment:3

LGTM. Just waiting for the patchbot...

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@egourgoulhon
Copy link
Member

comment:4

Replying to @egourgoulhon:

LGTM. Just waiting for the patchbot...

It came and is all green! Thanks for the ticket.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 31, 2021

comment:5

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Sep 7, 2021

comment:6

Merge conflict

@vbraun
Copy link
Member

vbraun commented Sep 13, 2021

Changed branch from u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules to ac82dd2

@vbraun vbraun closed this as completed in a2af3f6 Sep 13, 2021
This was referenced Jan 30, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mkoeppe