homebrew llvm / clang - followup to #30835

[dimpase]

in #30835 problems with using clang(++) from Homebrew on macOS were found

• Pillow build broken
• PATH needs to be adjusted (?)

After Pillow update to 9.0.1 the only problem is caused by an obsolete workaround
for Darwin/XCode in Pillow's spkg-install. The branch here removes it.

Depends on #33116

Upstream: None of the above - read trac for reasoning.

CC: @mkoeppe @jhpalmieri

Component: build

Keywords: macOS, Darwin

Author: Dima Pasechnik

Branch/Commit: 9619910

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/32207

[dimpase]

Upstream: Reported upstream. No feedback yet.

[dimpase]

comment:2

reported here: python-pillow/Pillow#5622

[dimpase]

comment:3

the setup.py patch in Pillow is obsolete anyway, and should be removed.

[dimpase]

comment:4

python-pillow/Pillow#5624 provides a fix. Will backport here.

[dimpase]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, in a later stable release.

[dimpase]

New commits:

ae7304f	build/pkgs/llvm: New
26f40f2	tox.ini, build/bin/write-dockerfile.sh: Add configuration factor 'llvm'
7c61eb9	tox.ini [homebrew-llvm]: Set CC, CXX to full path
4592331	remove obsolete patch, replace it with one for #32207

[dimpase]

Commit: 4592331

[dimpase]

Branch: u/dimpase/packages/pillow/llvmclang_fix

[dimpase]

Author: Dima Pasechnik

[dimpase]

Dependencies: #30835

[mkoeppe]

comment:7

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

[dimpase]

Changed dependencies from #30835 to #33116

[dimpase]

comment:9

hopefully pillow problem will be fixed by #33116

[dimpase]

comment:10

we need to remove this obsolete (?) workaround to let Homebrew's clang do the job. Apparently also OK for Xcode's clang.

---

New commits:

a2967a2	update pillow to 9.0.1, remove its patches
c9f6fba	bump system freetype2 minimal version, for pillow
9619910	remove obsolete workaround

[dimpase]

Changed commit from 4592331 to 9619910

[dimpase]

Changed branch from u/dimpase/packages/pillow/llvmclang_fix to u/dimpase/packages/pillow/fixfor_homebrew_clang

[dimpase]

comment:11

The only thing to review here is removal of the Darwin-only Pillow workaround, which is no longer necessary, according to my tests.

Please review.

[dimpase]

Changed upstream from Fixed upstream, in a later stable release. to None of the above - read trac for reasoning.

[dimpase]

Changed keywords from none to macOS, Darwin

[jhpalmieri]

comment:14

Can someone remind me of why, in the pillow installation log file, it says toward the end

Successfully built Pillow
WARNING: Skipping Pillow as it is not installed.

[dimpase]

comment:15

I guess it's coming from pip ?

src/pip/_internal/req/req_install.py: logger.warning("Skipping %s as it is not installed.", self.name)

namely, before installing a newly built wheel, pip is called to uninstall the package.
But if it wasn't installed one gets this warning. Harmless.

[dimpase]

comment:16

$ pip uninstall foobar
WARNING: Skipping foobar as it is not installed.

[jhpalmieri]

comment:17

Pillow builds for me (with the standard gcc, not using homebrew's llvm etc.). Sage itself does not — see my recent post on sage-support — so I can't test further.

[dimpase]

comment:18

I understand that #33522 fixes the scipy error you're talking about. It has nothing to do with this ticket, I think.

[jhpalmieri]

comment:19

I think you're right, but I would like to see for myself that Sage builds with this branch (+#33522).

[jhpalmieri]

comment:20

I haven't checked llvm/clang, but it works with the standard OS X clang + homebrew's gfortran. Is this good enough?

[dimpase]

comment:21

Yes, that's good enough. Thanks.

[dimpase]

comment:22

in case, tests are running on #33512 comment:3

[jhpalmieri]

Reviewer: John Palmieri

[jhpalmieri]

comment:23

Great, let's merge it.

[GMS103]

comment:24

FWIW, Positive review on Apple Silicon M1 Macs with Homebrew up to date, both macOS 11.6.5 (Big Sur) with Xcode 13.2.1 and macOS 12.3 (Monterey) with Xcode 13.3.

[vbraun]

Changed branch from u/dimpase/packages/pillow/fixfor_homebrew_clang to 9619910