Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: Add spkg-configure.m4 and system package information; remove install script #31529

Closed
mkoeppe opened this issue Mar 20, 2021 · 90 comments
Closed

texlive: Add spkg-configure.m4 and system package information; remove install script #31529

mkoeppe opened this issue Mar 20, 2021 · 90 comments
Labels
c: packages: optional p: critical / 2 t: enhancement
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 20, 2021

Right now presence of tex is not tested, and texlive is included in system packages of _recommended.

In this ticket, we associate the tex system package with texlive instead.

We also test presence of latex packages that are needed for building the sage pdf documentation and make texlive a dependency of sagemath_doc_pdf.

We remove the install script due to lack of use and maintenance (#21922). Installing tex should not be the concern of SageMath.

CC: @slel @jhpalmieri @vbraun @videlec @seblabbe @kiwifb @antonio-rojas @tornaria

Component: packages: optional

Keywords: texlive, spkg-configure.m4

Author: Matthias Koeppe, Dima Pasechnik, Antonio Rojas, François Bissey

Branch/Commit: 7a1a1fe

Reviewer: Sébastien Labbé, Matthias Koeppe, Dima Pasechnik, Andrey Belgorodski

Issue created by migration from https://trac.sagemath.org/ticket/31529
@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 20, 2021
@slel
Copy link
Member

slel commented Mar 20, 2021

comment:1

To build the documentation in all languages I think we need

texlive-lang-cyrillic
texlive-lang-english
texlive-lang-european
texlive-lang-french
texlive-lang-german
texlive-lang-italian
texlive-lang-japanese
texlive-lang-polish
texlive-lang-portuguese
texlive-lang-spanish

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title texlive: Add spkg-configure.m4 and system package information texlive: Add spkg-configure.m4 and system package information; remove install script Mar 20, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 18, 2021

Dependencies: #31163

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 18, 2021

Branch: u/mkoeppe/texlive__add_spkg_configure_m4_and_system_package_information__remove_install_script

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 22, 2021

New commits:

2576f86build/make/Makefile.in: If a script package has no spkg-install, run "sage -info" and exit with error
feb8de7build/pkgs/: Remove spkg-install scripts for dummy script packages
8f782c0.github/workflows/tox-{optional,experimental}.yml: Do not try to test dummy script packages
ede6121Merge #31163
c34cfe4WIP

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 22, 2021

Commit: c34cfe4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 22, 2021

Work Issues: merge updated #31163

@dimpase
Copy link
Member

dimpase commented Dec 7, 2021

comment:9

as far as I am concerned it's almost ready - I'd only ask for spkg-install printing something meaningul.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 9, 2021

comment:10

This would need info whether the package is involved in building the binary distribution.

@dimpase
Copy link
Member

dimpase commented Dec 9, 2021

comment:11

I don't think our binary builds ship TeX.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2021

comment:12

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

985dcf1WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2022

Changed commit from c34cfe4 to 985dcf1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 24, 2022

Changed work issues from merge updated #31163 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 24, 2022

Changed dependencies from #31163 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 24, 2022

comment:17

The file build/pkgs/texlive/package-list.txt contains a list of packages.

$ git log --follow build/pkgs/texlive/package-list.txt 
commit 152d1348b35e23f0b675aa2eaddc09db1f8063e0
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Sat Jan 9 14:15:49 2016 +0100

    Move the texlive install script to a script-type package

commit 37ca6434c6af9c72cf0e524377131aab34fa077b
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Tue Mar 31 11:49:56 2015 +0200

    add two more texlive packages

commit 9f69d3af5bf8c4aeb9a53ca681786d4c1a15a1e5
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Fri Mar 20 20:10:09 2015 +0100

    add tkz to texlive packages

commit ef0319feee59186bf4139673e72c1234434aeba6
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Sun Mar 15 20:07:06 2015 +0100

    add packages required by IPython nbconvert

commit e8ac6085104bed4bcc0b3f56e830fa806f034def
Author: Volker Braun <vbraun.name@gmail.com>
Date:   Sat Feb 28 15:12:47 2015 +0100

    Initial version of the TeXlive install script

It does not appear to be used anywhere.

@jhpalmieri
Copy link
Member

comment:18

In the develop branch, that file is used in build/pkgs/texlive/spkg-install.py:

def install_packages():
    package_list_txt = os.path.join(
        os.path.dirname(__file__),
        'package-list.txt'
    )
    with open(package_list_txt) as f:
        package_list = f.read()
    ...

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

comment:57

Should add the Gentoo stuff before it gets reviewed.

New commits:

7b97dd4update list of gentoo packages

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

Changed branch from u/mkoeppe/packages/texlive/add_spkg_configure_m4_and_system_package_information__remove_install_script to u/fbissey/packages/texlive/add_spkg_configure_m4_and_system_package_information__remove_install_script

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

Changed commit from 8b2490e to 7b97dd4

@kiwifb
Copy link
Member

kiwifb commented Feb 1, 2022

Changed author from Matthias Koeppe, Dima Pasechnik, Antonio Rojas to Matthias Koeppe, Dima Pasechnik, Antonio Rojas, François Bissey

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2022

Changed reviewer from Sébastien Labbé to Sébastien Labbé, Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2022

comment:62

Let's get this in

@dimpase
Copy link
Member

dimpase commented Feb 5, 2022

Changed reviewer from Sébastien Labbé, Matthias Koeppe to Sébastien Labbé, Matthias Koeppe, Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Feb 5, 2022

comment:63

good to go

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 5, 2022

comment:64

Thanks!

@sheerluck
Copy link
Contributor

comment:65

Replying to @kiwifb:

Should add the Gentoo stuff before it gets reviewed.

I think gentoo.txt needs app-text/dvipng:

Checking whether SageMath should install SPKG texlive...
checking for pdflatex... /usr/bin/pdflatex
checking for latexmk... /usr/bin/latexmk
checking for dvipng... no                <--------- HERE!
checking for latex package fontspec... yes
checking for latex package xunicode... yes
checking for latex package xltxtra... yes
checking for latex package amssymb... yes
checking for latex package amsfonts... yes
checking for latex package graphicx... yes
checking for latex package mathrsfs... yes
checking for latex package textcomp... yes
checking for latex package tikz... yes
checking for latex package tikz-qtree... yes
checking for latex package iftex... yes
checking for latex package tkz-berge... yes
checking for latex package tkz-graph... yes
checking for latex package xy... yes
checking for latex package babel... yes
checking for latex package subfigure... yes
checking for latex package hyperref... yes
checking for latex package hypcap... yes
checking for latex package xr... yes
checking for latex package tgtermes... yes
checking for latex package fncychap... yes
configure: no suitable system package found for SPKG texlive

@kiwifb
Copy link
Member

kiwifb commented Feb 8, 2022

comment:66

darn missed that. It is a dependency of texlive if you have the png useflag which is of course not guaranteed by the distro file.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2022

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

7a1a1feadd dvipng to gentoo list of texlive related packages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 8, 2022

Changed commit from 7b97dd4 to 7a1a1fe

@kiwifb
Copy link
Member

kiwifb commented Feb 8, 2022

comment:68

@sheerluck can you double check my last commit and if everything is in right order put the ticket back to positive review. You can also add your name to the reviewer field if you wish.

@sheerluck
Copy link
Contributor

comment:69
Checking whether SageMath should install SPKG texlive...
checking for pdflatex... /usr/bin/pdflatex
checking for latexmk... /usr/bin/latexmk
checking for dvipng... /usr/bin/dvipng
checking for latex package fontspec... yes
...
configure: will use system package and not install SPKG texlive

@slel
Copy link
Member

slel commented Feb 8, 2022

Changed reviewer from Sébastien Labbé, Matthias Koeppe, Dima Pasechnik to Sébastien Labbé, Matthias Koeppe, Dima Pasechnik, Andrey Belgorodski

@slel
Copy link
Member

slel commented Feb 8, 2022

Changed keywords from none to texlive, spkg-configure.m4

@vbraun
Copy link
Member

vbraun commented Feb 13, 2022

Changed branch from u/fbissey/packages/texlive/add_spkg_configure_m4_and_system_package_information__remove_install_script to 7a1a1fe

@vbraun vbraun closed this as completed in b34c0d5 Feb 13, 2022
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
9 participants
@kiwifb @vbraun @dimpase @jhpalmieri @seblabbe @slel @sheerluck @mkoeppe @antonio-rojas