Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.misc.cython: Replace imports from distutils by setuptools #31349

Closed
mkoeppe opened this issue Feb 6, 2021 · 12 comments
Closed

sage.misc.cython: Replace imports from distutils by setuptools #31349

mkoeppe opened this issue Feb 6, 2021 · 12 comments
Labels
c: porting p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 6, 2021

part of #31295 (Meta-ticket: Replace imports from deprecated distutils).

We fall back to distutils if setuptools cannot be imported.
In this way we avoid having to declare setuptools as an install_requires of sagelib (for now).

CC: @fchapoton @jhpalmieri @kiwifb @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: faa8ec6

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/31349
@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 6, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Branch: u/mkoeppe/sage_misc_cython__replace_imports_from_distutils_by_setuptools

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Commit: faa8ec6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

New commits:

faa8ec6sage.misc.cython: Try using setuptools, fall back to distutils

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member

comment:6

Looks okay to me. Is there a reason to not "declare setuptools as an install_requires of sagelib"?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2021

comment:7

Mostly I wanted to avoid touching the files which are modified in #30913.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member

comment:8

Okay, makes sense.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 20, 2021

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/mkoeppe/sage_misc_cython__replace_imports_from_distutils_by_setuptools to faa8ec6

@vbraun vbraun closed this as completed in a38abbb Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe