Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent JSmol from phoning home #30030

Closed
jcamp0x2a mannequin opened this issue Jun 30, 2020 · 9 comments
Closed

Prevent JSmol from phoning home #30030

jcamp0x2a mannequin opened this issue Jun 30, 2020 · 9 comments

Comments

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Jun 30, 2020

The JSmol library -- invoked when using viewer='jmol' or viewer='canvas3d' from the Jupyter notebook -- is sending an HTTP request to a tracking script at chemapps.stolaf.edu that then uses Google Analytics:

GET /jmol/JmolTracker.php?id=UA-45940799-1&applet=Jmol._Canvas2D%20(Jmol)&version=2019-06-08%2000:17:46%20(JSmol/j2s)&appver=14.29.51&url=about%3Asrcdoc HTTP/1.1
Host: chemapps.stolaf.edu
User-Agent: ...
...
Referer: http://localhost:8888/notebooks/.../mynotebook.ipynb
...

These requests are not essential to the functioning of JSmol, so in the interest of furthering users' digital privacy, the proposed change prevents such requests from occurring.

The instruction to disable the tracking request was found at: https://sourceforge.net/p/jmol/mailman/message/31869453/

Component: graphics

Keywords: jmol jsmol tracker tracking telemetry privacy

Author: Joshua Campbell

Branch: bdd7bf6

Reviewer: Paul Masson

Issue created by migration from https://trac.sagemath.org/ticket/30030

@jcamp0x2a jcamp0x2a mannequin added this to the sage-9.2 milestone Jun 30, 2020
@jcamp0x2a jcamp0x2a mannequin added c: graphics labels Jun 30, 2020
@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Jun 30, 2020

comment:1

When this is ready for review you can mark it positive for me

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Jun 30, 2020

Reviewer: Paul Masson

@jcamp0x2a
Copy link
Mannequin Author

jcamp0x2a mannequin commented Jun 30, 2020

comment:2

Sorry, I thought I had put it in review earlier, but I was in error. I will move it to positive review as requested.

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from u/gh-jcamp0x2a/disable-jsmol-tracker to bdd7bf6

@dimpase
Copy link
Member

dimpase commented Jul 11, 2020

comment:5

This has broken Sage notebook.
Namely, after

./sage --notebook

neither existing notebooks, not new notebooks (be they Sage or Python3)

may be opened

@dimpase
Copy link
Member

dimpase commented Jul 11, 2020

Changed commit from bdd7bf6 to none

@dimpase
Copy link
Member

dimpase commented Jul 11, 2020

comment:6

however, reverting/rebuilding Sage with this commit out, and then pulling the branch and re-building makes everything work (or "work") - could it be some caching going on?

I see this on !Linux/Firefox

@dimpase
Copy link
Member

dimpase commented Jul 11, 2020

comment:7

In the first run I saw some Warnings (404 on Mathjax stuff) - perhaps it was a temporary issue.

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Jul 11, 2020

comment:8

Replying to @dimpase:

In the first run I saw some Warnings (404 on Mathjax stuff) - perhaps it was a temporary issue.

The problems with the notebook are not due to this ticket. Starting a new notebook with 9.2.beta4 I get errors that Mathjax cannot be found because the nbextensions directory is not being served by the local server. That is a serious issue that would not be caused by turning off Google tracking in JSmol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants