-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent JSmol from phoning home #30030
Comments
comment:1
When this is ready for review you can mark it positive for me |
Reviewer: Paul Masson |
comment:2
Sorry, I thought I had put it in review earlier, but I was in error. I will move it to positive review as requested. |
Changed branch from u/gh-jcamp0x2a/disable-jsmol-tracker to |
comment:5
This has broken Sage notebook.
neither existing notebooks, not new notebooks (be they Sage or Python3) may be opened |
Changed commit from |
comment:6
however, reverting/rebuilding Sage with this commit out, and then pulling the branch and re-building makes everything work (or "work") - could it be some caching going on? I see this on !Linux/Firefox |
comment:7
In the first run I saw some Warnings (404 on Mathjax stuff) - perhaps it was a temporary issue. |
comment:8
Replying to @dimpase:
The problems with the notebook are not due to this ticket. Starting a new notebook with 9.2.beta4 I get errors that Mathjax cannot be found because the |
The JSmol library -- invoked when using
viewer='jmol'
orviewer='canvas3d'
from the Jupyter notebook -- is sending an HTTP request to a tracking script at chemapps.stolaf.edu that then uses Google Analytics:These requests are not essential to the functioning of JSmol, so in the interest of furthering users' digital privacy, the proposed change prevents such requests from occurring.
The instruction to disable the tracking request was found at: https://sourceforge.net/p/jmol/mailman/message/31869453/
Component: graphics
Keywords: jmol jsmol tracker tracking telemetry privacy
Author: Joshua Campbell
Branch:
bdd7bf6
Reviewer: Paul Masson
Issue created by migration from https://trac.sagemath.org/ticket/30030
The text was updated successfully, but these errors were encountered: