Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to cysignals 1.7.2 #25814

Closed
jdemeyer opened this issue Jul 10, 2018 · 15 comments
Closed

Upgrade to cysignals 1.7.2 #25814

jdemeyer opened this issue Jul 10, 2018 · 15 comments
Labels
c: packages: standard p: blocker / 1 t: enhancement
Milestone
sage-8.3

Comments

@jdemeyer
Copy link

Fixes: #25482

Tarball: https://files.pythonhosted.org/packages/db/49/4330c134dead86c953951f08b31cf8f4c6023073b7e5caf2d2246c9eecf6/cysignals-1.7.2.tar.gz

CC: @antonio-rojas @embray @kiwifb @timokau @infinity0 @slel @tobihan @sagetrac-tmonteil

Component: packages: standard

Keywords: upgrade, cysignals

Author: Jeroen Demeyer

Branch/Commit: a41caf4

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/25814
@jdemeyer jdemeyer added this to the sage-8.3 milestone Jul 10, 2018
@timokau
Copy link
Contributor

timokau commented Jul 11, 2018

comment:1

Already updated the nix package, it was a trivial update.

@jdemeyer

This comment has been minimized.

Sign in to view
@slel
Copy link
Member

slel commented Jul 12, 2018

Changed keywords from none to upgrade, cysignals

@slel slel changed the title Upgrade cysignals Upgrade to cysignals 1.7.2 Jul 12, 2018
@embray
Copy link
Contributor

embray commented Jul 12, 2018

comment:4

Then this just needs the necessary updates to build/pkgs/cysignals?

@embray
Copy link
Contributor

embray commented Jul 12, 2018

Branch: u/embray/pkgs/cysignals/update-1.7.2

@embray
Copy link
Contributor

embray commented Jul 12, 2018

New commits:

a41caf4Upgrade cysignals to 1.7.2

@embray
Copy link
Contributor

embray commented Jul 12, 2018

Commit: a41caf4

@embray
Copy link
Contributor

embray commented Jul 12, 2018

comment:6

Confirmed that with this branch plus #25620 all ptestlong tests pass on Cygwin \o/

@jdemeyer
Copy link
Author

Reviewer: Erik Bray

@jdemeyer
Copy link
Author

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 16, 2018

comment:9

Doesn't fix a supported platform -> Not a blocker

@embray
Copy link
Contributor

embray commented Jul 16, 2018

comment:10

Windows is a supported platform.

@vbraun
Copy link
Member

vbraun commented Jul 16, 2018

comment:11

No buildbot => not a fully supported platform

@embray

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Jul 22, 2018

Changed branch from u/embray/pkgs/cysignals/update-1.7.2 to a41caf4

@vbraun vbraun closed this as completed in 4abd985 Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: blocker / 1 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
5 participants
@embray @vbraun @slel @jdemeyer @timokau