Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccuracy in symbolic series result on 32bit Linux #25688

Closed
rwst opened this issue Jun 28, 2018 · 18 comments
Closed

Inaccuracy in symbolic series result on 32bit Linux #25688

rwst opened this issue Jun 28, 2018 · 18 comments

Comments

@rwst
Copy link

rwst commented Jun 28, 2018

From #24838 comment:64

On 32-bit:

File "src/sage/functions/hypergeometric.py", line 148, in sage.functions.hypergeometric
Failed example:
    hypergeometric_U(2, 2, x).series(x == 3, 100).subs(x=1).n()
Expected:
    0.403652637676806
Got:
    0.403651580752398

Pynac is not involved in the numerics (hypergeometric_U is not a GinacFunction), so the hypothesis is that the expression before .n() is different with 32bit Linux pynac-0.7.22.

CC: @slel @sagetrac-tmonteil

Component: symbolics

Keywords: pynac, 32-bit, overflow

Author: Dave Morris

Branch/Commit: 689e08f

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/25688

@rwst rwst added this to the sage-8.3 milestone Jun 28, 2018
@DaveWitteMorris
Copy link
Member

Branch: public/25688

@DaveWitteMorris
Copy link
Member

Commit: e8ee3fc

@DaveWitteMorris
Copy link
Member

comment:2

This bug is fixed by the pynac patch in #31585. (So the inaccuracy in the sum is due to an arithmetic overflow.)

There is only new commit in the branch here. It just deletes the "known bug" tag from the doctest in src/sage/functions/hypergeometric.py that is in the description of this ticket.


New commits:

f1a99fatrac 31585 pynac overflow patch
3fcf072add doctests
fdde3d9update pynac patch level
e8ee3fctrac 25688 remove "known bug" tag

@DaveWitteMorris
Copy link
Member

Changed keywords from none to pynac, 32-bit, overflow

@DaveWitteMorris
Copy link
Member

Dependencies: #31585

@DaveWitteMorris
Copy link
Member

Author: Dave Morris

@DaveWitteMorris
Copy link
Member

Changed branch from public/25688 to public/25688r1

@DaveWitteMorris
Copy link
Member

Changed commit from e8ee3fc to 73e975c

@DaveWitteMorris
Copy link
Member

comment:4

Rebased on the new #31585 that eliminates a merge conflict.


New commits:

ecb99c8trac 31585 pynac overflow patch
2d04fa4add doctests
5a340ceupdate pynac patch level
73e975ctrac 25688 remove "known bug" tag

@slel
Copy link
Member

slel commented Jul 24, 2021

comment:5

Please rebase.

@DaveWitteMorris
Copy link
Member

Changed branch from public/25688r1 to public/25688r2

@DaveWitteMorris
Copy link
Member

Changed dependencies from #31585 to none

@DaveWitteMorris
Copy link
Member

Changed commit from 73e975c to 689e08f

@DaveWitteMorris
Copy link
Member

comment:7

Thanks for pointing out the merge conflict -- I hadn't noticed. I rebased on 9.4b6 (and deleted the dependency on #31585, which has already been merged).


New commits:

689e08ftrac 25688 remove "known bug" tag

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:10

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 8, 2022

Reviewer: Matthias Koeppe

@DaveWitteMorris
Copy link
Member

comment:12

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2022

Changed branch from public/25688r2 to 689e08f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants