package primecount 4.3

[videlec]

The goal of this ticket is to

• package Kim Walish's primecount package (the version of prime_pi
  in Sage has bugs, see Fix prime_pi errors and make primecount standard #24960)
• provide an experimental interface to it in arith/prime_pi.pyx (that will
  be merged with the current prime_pi in Sage in update and promote spkg primecount #25009).

Note that

• primecount's build system uses cmake, which needs an upgrade (see Upgrade cmake to 3.11.0 #25109)
• the latest release of primecount should work on both big-endian and little-indian
  processors but has been tested successfully
• linking on Mac OSX looks fishy but seems to work fine

Tarball (to be renamed primecount-4.3.tar.gz in Sage):

• https://github.com/kimwalisch/primecount/archive/v4.3.tar.gz

This ticket led to opening and solving an upstream issue,
leading to improvements in the build and documentation:

• make install fail kimwalisch/primecount#11

Depends on #25109

CC: @jpflori @kiwifb @vinklein @slel

Component: packages: optional

Keywords: thursdaysbdx

Author: Vincent Delecroix

Branch/Commit: 6f73fad

Reviewer: Vincent Klein, François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/24966

[dimpase]

comment:2

We are told that this is little-endian only. So this in its present form can at best become an experimental package, AFAIK.

[videlec]

comment:3

Thanks for the clarification Dima. It was actually a question that Kim Walish asked on github.

[ohanar]

comment:5

It appears that Kim has put out a new release of primecount with big-endian support.

[dimpase]

comment:6

I just checked the latest release on (big-endian) SPARC, it appears to work.
(I tried ./primecount 1e11 with different algorithms, it worked)

I didn't test with OpenMP. Should I?

[videlec]

Commit: c5bcc9e

[videlec]

New commits:

c5bcc9e

package primecount

[videlec]

Branch: u/vdelecroix/24966

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

559ef72

package primecount

[sagetrac-git]

Changed commit from c5bcc9e to 559ef72

[jdemeyer]

comment:9

This should use the modern style spkg-install script with the sdh_ functions.

[dimpase]

comment:10

In spkg-check one needs $MAKE test rather than $MAKE check.

Must be another cmake-ism... :-)

[sagetrac-git]

Changed commit from 559ef72 to 1297aba

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1297aba

package primecount

[kiwifb]

comment:57

OK I have read other reports. Did you run xcode-select --install after installing/upgrading xcode? This unfortunately has to be done regularly after upgrades otherwise some stuff is missing at the root level.

[vinklein]

comment:58

Replying to @kiwifb:

OK I have read other reports. Did you run xcode-select --install after installing/upgrading xcode?

Yes i tried this one. It just say command line tools are already installed. And xcode doesn't appear with softwareupdate --list

[kiwifb]

comment:59

Hum... could be the way cmake is built and installed Homebrew/homebrew-core#15232 Homebrew/homebrew-core#19372 it looks like we need to upgrade cmake to fix this.

[vinklein]

comment:60

Indeed it works fine after upgrading sage's cmake package to 3.11.0

[vinklein]

Dependencies: 25109

[vinklein]

Changed dependencies from 25109 to #25109

[vinklein]

comment:65

tests are currently runnings on MacOS 10.13.4 and on Ubuntu 16.04

[kiwifb]

comment:66

I really want to see -DCMAKE_VERBOSE_MAKEFILE=ON in spkg-install. Once it is done, it is a positive review from me.

[kiwifb]

Changed reviewer from Vincent Klein to Vincent Klein, François Bissey

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6f73fad

CMAKE_VERBOSE_MAKEFILE=ON

[sagetrac-git]

Changed commit from e60448c to 6f73fad

[videlec]

comment:68

great

[slel]

comment:69

The ticket description has this somewhat puzzling statement:

should work on both big-endian and little-indian
processors but has been tested successfully

Can someone clarify?

[vbraun]

Changed branch from u/vdelecroix/24966 to 6f73fad