Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gambit does not install #24840

Closed
jdemeyer opened this issue Feb 26, 2018 · 13 comments
Closed

gambit does not install #24840

jdemeyer opened this issue Feb 26, 2018 · 13 comments
Labels
c: packages: optional p: blocker / 1 t: bug
Milestone
sage-8.2

Comments

@jdemeyer
Copy link

Upstream: gambitproject/gambit#232

Upstream: Reported upstream. No feedback yet.

Component: packages: optional

Author: Jeroen Demeyer

Branch/Commit: b3bcbc1

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24840
@jdemeyer jdemeyer added this to the sage-8.2 milestone Feb 26, 2018
@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

Upstream: Reported upstream. No feedback yet.

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Use pip to install gambit Python interface gambit does not install Feb 26, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/gambit_does_not_install

@jdemeyer
Copy link
Author

Commit: 16e377e

@jdemeyer
Copy link
Author

New commits:

16e377eFix build of gambit

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2018

comment:5

LGTM.

@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2018

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

b3bcbc1Fix build of gambit

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 27, 2018

Changed commit from 16e377e to b3bcbc1

@jdemeyer
Copy link
Author

comment:8

I made an upstream pull request and changed the comment in spkg-install.

@vbraun
Copy link
Member

vbraun commented Mar 4, 2018

Changed branch from u/jdemeyer/gambit_does_not_install to b3bcbc1

@vbraun vbraun closed this as completed in c4c315e Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer