Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve polynomial templates #17476

Open
jdemeyer opened this issue Dec 9, 2014 · 1 comment
Open

Improve polynomial templates #17476

jdemeyer opened this issue Dec 9, 2014 · 1 comment

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 9, 2014

The files src/sage/rings/polynomial/polynomial_template.pxi and src/sage/libs/flint/nmod_poly_linkage.pxi are a mess:

  1. They are almost completely undocumented
  2. The functions in it cannot be interrupted (see for example Let exponentiation of polynomial using FLINT nmod type be interrupted #17470)
  3. celement_pow should really be split up in 2 functions: one for the modular case, one for normal powering
  4. This shouldn't be needed:
        except OverflowError:
            return Polynomial.__pow__(self, ee, modulus)

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/17476

@jdemeyer jdemeyer added this to the sage-6.5 milestone Dec 9, 2014
@jdemeyer jdemeyer changed the title Polynomial templates are a mess Improve polynomial templates Dec 9, 2014
@jpflori
Copy link

jpflori commented Dec 9, 2014

comment:2

We should surely have a look at the files organization for p-adics templates as these were written much more recently and possibly in a cleaner way.

@mkoeppe mkoeppe removed this from the sage-6.5 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants