inclusion of the ore_algebra within Sage

[zimmermann6]

the group of Manuel Kauers at RISC develops the ore_algebra package
(http://www.risc.jku.at/research/combinat/software/ore_algebra/index.php) which is similar to the
Maple gfun package (but more powerful since it works in more general rings), and will be extended to
the multivariate case. A small example with version 0.1:

  sage: from ore_algebra import *
  sage: R.<x> = QQ[]; A.<Dx> = OreAlgebra(R)
  sage: deq = guess([1,1,2,3,5,8,13,21],A)
  sage: deq
  (x^2 + x - 1)*Dx + 2*x + 1
  sage: rec = A(deq).to_S(A2)
  sage: rec
  (-n - 2)*Sn^2 + (n + 2)*Sn + n + 2

New optional spkg: http://www.risc.jku.at/research/combinat/software/ore_algebra/ore_algebra-0.1.spkg

CC: @mkauers @haraldschilly

Component: packages: optional

Keywords: gfun Mgfun Ore guessing

Reviewer: Marc Mezzarobba, Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/16008

[rwst]

comment:1

See also #15714 and the meta ticket #11515. Of course ore_algebra has more in it than just guessing.

[rwst]

comment:2

The link is http://www.risc.jku.at/research/combinat/software/ore_algebra/ore_algebra-0.1.spkg and it installs out of the box.

[mezzarobba]

comment:3

Hmm, what is it that needs review here?

[rwst]

comment:4

Well I thought I can't set both review and positive... but since you reviewed it too, I'll just go ahead. Thanks.

[mezzarobba]

comment:5

I don't understand: ore_algebra is not included in sage, is it? It is not even an optional package, just an external package that uses sage and happens to be distributed as an spkg...

[rwst]

comment:6

This ticket is closed when ore_algebra is included as optional package. Any other code you need to use the package should go in another ticket.

[mezzarobba]

comment:7

Replying to @rwst:

This ticket is closed when ore_algebra is included as optional package.

But it isn't, is it?

~/co/sage:develop$ ls build/pkgs/ore*
ls: cannot access build/pkgs/ore*: No such file or directory
(exit 2) 
~/co/sage:develop$ sage -optional | grep ore
(exit 1) 

Or did you forget to attach a branch to this ticket?

[rwst]

comment:8

But why? It's all included in the SPKG and works. Also, the docs state: Note that the top-level directory inside the tarball is renamed to src before calling the spkg-install script. So you really mean that I should provide an spkg-install script that calls the package's spkg-install script? Should it overwrite other files in build/... with versions in the provided package itself?

[mezzarobba]

comment:9

Replying to @rwst:

But why? It's all included in the SPKG and works.

Sure, ore_algebra is available as an spkg. It already was Paul openeed this ticket. So the way I understand the ticket's description is that it is about including ore_algebra into sage itself (either as a package, or perhaps by making it part of the sage library, if Manuel & co are interested—I know they were considering it at some point, but I don't know how things are standing now). I could understand that you suggest to close the ticket as wontfix if you believe it should just stay an external package, but I don't think the issue is fixed.

[rwst]

comment:10

I do not suggest to close the ticket as wontfix. I never said that. What I expect is that someone sets positive, and since this ticket is in packages:optional I then expect the release manager to download the SPKG and himself copy the relevant files from that into build/... as well as providing the src/ as a tarball. BUT the mgt won't notice at all as long it's not positive.

Again, this ticket is in packages:optional, and that means when closed the package will be optional.

[mezzarobba]

comment:11

Replying to @rwst:

I do not suggest to close the ticket as wontfix. I never said that. What I expect is that someone sets positive, and since this ticket is in packages:optional I then expect the release manager to download the SPKG and himself copy the relevant files from that into build/... as well as providing the src/ as a tarball. BUT the mgt won't notice at all as long it's not positive.

Sorry, I never reviewed optional packages before, and I thought the idea was to use the ticket to review that the package worked well once all that was done, not to decide whether to make it an optional package at all. But if positive review only means "yes, this should be an optional package," then I agree with you.

[rwst]

Branch: u/rws/inclusion_of_the_ore_algebra_within_sage

[rwst]

comment:13

Thanks. John Cremona clarified the procedure in https://groups.google.com/forum/#!topic/sage-devel/jopuoWO1Fvk

---

New commits:

002e19f

Trac 16008: copy spkg-install and SPKG.txt into build/pkgs/ore-algebra

[rwst]

Commit: 002e19f

[rwst]

Reviewer: Marc Mezzarobba, Ralf Stephan

[vbraun]

comment:14

New-style optional packges must be tar.gz/tar.bz. We can include the existing spkg as optional, but then we don't need anything from the git branch.

[rwst]

comment:15

So is there anything missing for this ticket?

[vbraun]

comment:16

The attached git branch is incomplete and there is no tarball. Is the ticket about updating the legacy spkg or creating a new-style optional package? I'm confused...

[rwst]

comment:17

This is about taking the published SPKG and using it to create an optional package. You said elsewhere that a functional SPKG suffices for optional package creation. I created the branch before I knew that.

[vbraun]

comment:18

Harald: can you mirror it?

[vbraun]

Changed branch from u/rws/inclusion_of_the_ore_algebra_within_sage to none

[vbraun]

Changed commit from 002e19f to none

[haraldschilly]

comment:19

yes, done. ore_algebra is on the servers