Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QQ._factor_univariate_polynomial() #13274

Closed
saraedum opened this issue Jul 19, 2012 · 9 comments
Closed

Add QQ._factor_univariate_polynomial() #13274

saraedum opened this issue Jul 19, 2012 · 9 comments
Assignees
@malb
Labels
c: commutative algebra good first issue p: trivial / 5
Milestone
sage-6.2

Comments

@saraedum
Copy link
Member

As a part of #11731, transfer the code which does the factorization over QQ from sage.rings.polynomial.polynomial_element.Polynomial.factor() to QQ._factor_univariate_polynomial().

Depends on #13272

Component: commutative algebra

Author: Julian Rueth

Branch/Commit: 6c85a8f

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/13274
@saraedum saraedum added this to the sage-5.11 milestone Jul 19, 2012
@saraedum
Copy link
Member Author

Attachment: trac_13274.patch.gz

@pjbruin
Copy link
Contributor

pjbruin commented Jun 15, 2013

comment:2

The patch no longer applies correctly to Sage 5.10.rc1; can you rebase it?

@pjbruin
Copy link
Contributor

pjbruin commented Jun 15, 2013

Reviewer: Peter Bruin

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@rwst
Copy link

rwst commented Feb 12, 2014

Branch: u/rws/ticket/13274

@rwst
Copy link

rwst commented Feb 12, 2014

comment:7

rebased Julian's patch

New commits:

cf8b120Trac 13274: Added QQ._factor_univariate_polynomial

@rwst
Copy link

rwst commented Feb 12, 2014

Commit: cf8b120

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2014

Changed commit from cf8b120 to 6c85a8f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

6c85a8fMerge branch 'develop' into ticket/13274

@vbraun
Copy link
Member

vbraun commented Feb 26, 2014

Changed branch from u/rws/ticket/13274 to 6c85a8f

@vbraun vbraun closed this as completed in e222964 Feb 26, 2014
@haikona haikona mannequin mentioned this issue Dec 29, 2022
Open
@saraedum saraedum mentioned this issue Feb 26, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malb malb

Labels
c: commutative algebra good first issue p: trivial / 5
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
6 participants
@saraedum @vbraun @rwst @malb @jdemeyer @pjbruin