-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root poset should treat type A1 properly #12838
Comments
Reviewer: Frédéric Chapoton |
comment:2
In sage/combinat/root_system/root_system.py, it should be written
(i.e. there are missing backquotes) Otherwise, it seems ok. |
comment:3
Replying to @fchapoton:
done. |
comment:6
This patch needs a commit message and also needs to be rebased to sage-5.0.beta14 (or later). |
comment:7
ping |
comment:8
Replying to @jdemeyer:
Sorry for being slow... I added a commit message -- the patch applies smoothly on 5.0.rc0. |
Attachment: trac_12838-root_poset_A1-cs.patch.gz |
comment:9
Not quite smoothly:
Anyway, I rebased it. |
Merged: sage-5.1.beta0 |
The patch fixes the issue that the one element root poset in type A1 was not returned correctly.
I also added the facade option for root posets.
Component: combinatorics
Keywords: root poset
Author: Christian Stump
Reviewer: Frédéric Chapoton
Merged: sage-5.1.beta0
Issue created by migration from https://trac.sagemath.org/ticket/12838
The text was updated successfully, but these errors were encountered: