Typo in sage.combinat.sf.classical

[roed314]

There's a typo in the _element_constructor_, revealed by the new doctesting implementation.

sage: McdJ = MacdonaldPolynomialsJ(QQ)
sage: s = SymmetricFunctions(McdJ.base_ring()).s()
sage: s._element_constructor(McdJ(s[2,1])
BOOM!

CC: @mwhansen

Component: combinatorics

Author: David Roe

Reviewer: Nathann Cohen, Nicolas M. Thiéry, David Loeffler

Merged: sage-5.0.beta12

Issue created by migration from https://trac.sagemath.org/ticket/12381

[nathanncohen]

comment:2

Looks good but there is a parenthesis missing in your doctest :-)

Nathann

[nthiery]

comment:3

I confirm. Either of you can put a positive review once the ) is added, and it is confirmed (e.g. by the buildbot) that the test pass.

[roed314]

Attachment: 12381.patch.gz

[roed314]

comment:4

Done. Once patchbot confirms tests pass then everything is good.

[loefflerd]

comment:6

Ping! The patchbot does indeed confirm that tests pass, so are we done?

[roed314]

comment:7

I think so, but I can't give my own patch a positive review....

[loefflerd]

Reviewer: Nathann Cohen, Nicolas Thiery, David Loeffler

[jdemeyer]

Merged: sage-5.0.beta12

[jdemeyer]

Changed reviewer from Nathann Cohen, Nicolas Thiery, David Loeffler to Nathann Cohen, Nicolas M. Thiéry, David Loeffler