Create the category of SetsWithGrading #10193

nthiery · 2010-10-31T09:31:54Z

The patch creates the category SetsWithGrading (with an example: non negative integers, graded by themselves) and puts WeightedIntegerVectors into this category.

See also: #10194

Apply:

Depends on #6495
Depends on #13605

CC: @sagetrac-sage-combinat @sagetrac-nborie

Component: combinatorics

Keywords: enumerated sets, sd35.5, days45

Author: Nicolas M. Thiéry, Vincent Delecroix

Reviewer: Nicolas Borie, Travis Scrimshaw

Merged: sage-5.11.beta0

Issue created by migration from https://trac.sagemath.org/ticket/10193

The text was updated successfully, but these errors were encountered:

mwhansen · 2010-11-01T20:44:05Z

comment:4

It seems like it would be better to use degree as opposed to size for consistency with the "standard" graded things. Also, it seems like it might be better to have the degree method implemented on the parents. It could be somewhat confusing if the degree method on the elements corresponded to a different grading than the parent it belongs to.

hivert · 2011-06-08T07:23:18Z

comment:5

Hi ! What is the status of this one ?

zimmermann6 · 2012-01-11T12:53:44Z

comment:6

Hi, here at SD35.5 I wanted to review #9280, but I see it depends on this ticket, which did not
progress since 15 months. Is this ticket dead?

Paul

PS: moreover the patch url is dead...

zimmermann6 · 2012-01-11T12:53:44Z

Changed keywords from enumerated sets to enumerated sets, sd35.5

nthiery · 2012-01-11T13:50:44Z

comment:7

Replying to @zimmermann6:

Hi, here at SD35.5 I wanted to review #9280, but I see it depends on this ticket, which did not
progress since 15 months. Is this ticket dead?

We just discussed it with Vincent Delecroix, and where planning to
finalize/review it during the Sage-Combinat days in Cernay (early February).

PS: moreover the patch url is dead...

Should be fixed now.

tscrim · 2012-12-17T08:47:27Z

comment:8

Hey Nicolas and Florent (and Vincent),

I was wondering what the status of this patch is since #13605 is currently based on this patch. I can commute #13605 past, but I would prefer to keep the current order (especially if this patch is close to being completed).

Thank you,

Travis

tscrim · 2013-01-31T22:39:42Z

Dependencies: #13605

tscrim · 2013-01-31T22:39:42Z

comment:9

Note that this will be swapped with #13605 in the combinat queue once Andrew uploads his review patch.

videlec · 2013-02-13T22:45:07Z

Changed author from Nicolas M. Thiéry to Nicolas M. Thiéry, Vincent Delecroix

nthiery · 2013-02-14T00:00:51Z

comment:13

TODO: add an example!

videlec · 2013-02-14T22:37:52Z

comment:15

Attachment: trac_10193-graded_sets.patch.gz

What's new:

remove the changes for partitions as it affects Partition options and cleanup partitions documentation #13605
rename GradedSets to SetsWithGrading
creation of an example (sage.categories.examples.sets_with_grading)
fix documentation

Vincent

tscrim · 2013-02-22T14:26:16Z

comment:17

Hey Vincent,

Let us know when the rebased patch over #6495 is up and ready for review.

Thanks,

Travis

tscrim · 2013-02-22T14:26:16Z

Changed keywords from enumerated sets, sd35.5 to enumerated sets, sd35.5, days45

tscrim · 2013-02-22T14:26:16Z

Changed dependencies from #13605 to #6495 #13605

tscrim · 2013-04-30T18:04:08Z

comment:25

Hey,

A few comments/questions:

I prefer the name GradedSets over SetsWithGrading, it's a more natural name to me.
The example, I don't think there should be the need for another NonNegativeIntegers class. Can't we just use the existing sage.sets.NonNegativeIntegers with the required methods and placed in this category?
Similar to above, I'd like to see all sets which belong actually into this category. Or at least a few more of the big classes.
Grade should be implemented as an abstract Element method
I don't like the default implementation of graded_component() since it assumes the first argument of subset (which may not be implemented) is the graded component. If you want to use the subset() method, you should call it with self.subset(grade=grade).
It's not well documented what methods must be implemented. The "automatic" way is to make them @abstract_methods.

Here's also some more wish-list type things that I'd like to see, but can wait for a followup ticket:

Simple API for grading shifts
Checking that morphisms preserve grading
Make degree() call grade() (thus act like an alias, unfortunately in categories you can't simply make an alias by degree = grade [it will reference the wrong function]).

Thanks,

Travis

tscrim · 2013-04-30T18:04:08Z

Changed reviewer from Jason Bandlow, Franco Saliola, ... to Nicolas Borie, Travis Scrimshaw

tscrim · 2013-04-30T21:25:32Z

comment:26

I just talked with Nicolas T. and basically my previous comments are to be disregarded except the documentation of the methods which need to be implemented needs to be improved.

Best,

Travis

nthiery · 2013-04-30T22:27:17Z

comment:27

Replying to @tscrim:

I just talked with Nicolas T. and basically my previous comments are to be disregarded except the documentation of the methods which need to be implemented needs to be improved.

I should add that those objections were natural! It would be good to explain in the documentation why, for example, SetsWithGrading rather than GradedSets. But this patch has been waiting long enough and it needs to be finally be put to real use; let's not delay it for this reason.

+1 as well on the feature requests in a later patch! (except for degree=grade for which I'd rather wait until we have some large scale feedback to see if there really would be a desire for it).

tscrim · 2013-06-01T17:45:59Z

comment:28

Here's a review patch which describes what needs to be implemented and some other minor doc fixes. If you're happy with the changes, you can set this to positive review.

Best,

Travis

For patchbot:

Apply: trac_10193-graded_sets-rebased.patch trac_10193-graded_sets-review-ts.patch

videlec · 2013-06-01T18:12:58Z

comment:29

Hi,

Thanks Travis. I am not happy!! The last sentence of the documentation of the category is uncomprehensible and there should be a link to the example.

I will upload an ultimate patch in a minute...

Vincent

videlec · 2013-06-01T18:29:53Z

Attachment: trac_10193-graded_sets-more_doc-vd.patch.gz

videlec · 2013-06-01T18:30:53Z

comment:30

It also appears that the example was not included in the documentation...

Apply: trac_10193-graded_sets-rebased.patch trac_10193-graded_sets-review-ts.patch trac_10193-graded_sets-more_doc-vd.patch

tscrim · 2013-06-02T01:00:49Z

Attachment: trac_10193-graded_sets-review-ts.patch.gz

tscrim · 2013-06-02T01:04:25Z

comment:31

Hey Vincent,

I've folded your review patch in and made changes to that (very) poorly written sentence I wrote.

Best,

Travis

For patchbot:

Apply: trac_10193-graded_sets-rebased.patch trac_10193-graded_sets-review-ts.patch

videlec · 2013-06-02T07:31:03Z

comment:32

Hi Travis,

I've folded your review patch in and made changes to that (very) poorly written sentence I wrote.

Perfect! I am not sure it was yours (and your english is for sure better than mine). I remember the first time I learn how to do a parent and a category: I found useful when they were specifications and pointers !

Best
Vincent

jdemeyer · 2013-06-06T12:30:54Z

Merged: sage-5.11.beta0

nthiery added c: combinatorics labels Oct 31, 2010

nthiery assigned sagetrac-sage-combinat Oct 31, 2010