Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OEIS database internet address to its new adrress #10056

Closed
sagetrac-tmonteil mannequin opened this issue Oct 2, 2010 · 12 comments
Closed

Change OEIS database internet address to its new adrress #10056

sagetrac-tmonteil mannequin opened this issue Oct 2, 2010 · 12 comments

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Oct 2, 2010

The On-Line Encyclopedia of Integer Sequences (OEIS) moved to http://oeis.org/.

Replacing any occurrence of http://www.research.att.com/~njas/sequences/ by http://oeis.org/classic/ should do the job.

The following files should be modified accordingly:

sage/coding/sd_codes.py
sage/combinat/sloane_functions.py
sage/databases/sloane.py
sage/graphs/digraph_generators.py
sage/graphs/graph_generators.py
sage/rings/rational_field.py
sage/symbolic/constants.py

CC: @sagetrac-sage-combinat @sagetrac-ssivek @seblabbe @sagetrac-abmasse

Component: combinatorics

Author: Thierry Monteil

Reviewer: Mike Hansen

Merged: sage-4.6.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10056

@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-4.6 milestone Oct 2, 2010
@sagetrac-tmonteil sagetrac-tmonteil mannequin self-assigned this Oct 2, 2010
@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Oct 3, 2010

Tested on 4.5.3

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Oct 3, 2010

Author: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Oct 3, 2010

comment:3

Attachment: trac_10056-new_oeis_address-tm.patch.gz

@sagetrac-tmonteil

This comment has been minimized.

@sagetrac-tmonteil sagetrac-tmonteil mannequin changed the title Change OEIS database address to its new adrress Change OEIS database internet address to its new adrress Oct 3, 2010
@sagetrac-abmasse
Copy link
Mannequin

sagetrac-abmasse mannequin commented Oct 3, 2010

comment:4

This shows why global constants are useful.

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Oct 7, 2010

comment:5

Hi Alexandre,

i agree with your remark, though this was not a hard job to make a grep and 14 replacements by hand (and we can hope that the url won't change every year). I just wanted to be sure that when Sloane will remove the encyclopedia from his personal webpage, sage will not be affected.

Note that only 5 replacements come inside the code as variables, whereas 9 replacements arise in the documentation or comments. Is there a way to put variables in the documentation too?

Another remark that may help for the future: note that there was a trick: the urls beginning with http://www.research.att.com/~njas/hadamard should not be replaced by the new OEIS url (there are about 3 of them in sage), since they come from another work of Sloane, which is not the encyclopedia of integer sequences. In particular, if there was a global variable named sloane_web_page then it would have made more work to separate both kind of links.

@mwhansen
Copy link
Contributor

comment:6

Looks good to me.

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@jdemeyer
Copy link

jdemeyer commented Nov 1, 2010

Merged: sage-4.6.1.alpha0

@jdemeyer jdemeyer closed this as completed Nov 1, 2010
@qed777 qed777 mannequin modified the milestones: sage-4.6, sage-4.6.1 Nov 1, 2010
@williamstein
Copy link
Contributor

comment:9

Hi,

I know this ticket is closed, but I showed it to the current maintainer of OEIS, and he had several issues with it, which could be addressed in followup ticket(s):

"That ticket describes an update but not one that would have been needed to fix broken links. We've kept all the old www.research.att.com links running throughout the transition, including now. I haven't looked at the sage code to see what it is doing, but the ticket refers to http://oeis.org/classic, which was a transitional URL and is now gone (but like the others still forward properly). For what it's worth, the URL base should be http://oeis.org/ not http://oeis.org/classic and searches should be of the form http://oeis.org/search?q=query"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants