From 6abb078e2f2ecca651b2ec4e50c337e43ac7103b Mon Sep 17 00:00:00 2001
From: "John H. Palmieri" <jhpalmieri64@gmail.com>
Date: Wed, 8 Jul 2020 13:45:22 -0700
Subject: [PATCH] trac 30093: skip test suite for curl, git, cmake

---
 build/pkgs/cmake/spkg-check.in | 30 +++++++-----------------------
 build/pkgs/curl/spkg-check.in  | 10 ++++++++--
 build/pkgs/git/spkg-check.in   | 13 +++++++------
 3 files changed, 22 insertions(+), 31 deletions(-)

diff --git a/build/pkgs/cmake/spkg-check.in b/build/pkgs/cmake/spkg-check.in
index 12244a0bfda..0a46f8bb57f 100644
--- a/build/pkgs/cmake/spkg-check.in
+++ b/build/pkgs/cmake/spkg-check.in
@@ -1,24 +1,8 @@
-if [ "$UNAME" = Darwin ]; then
-    CC=clang
-    CXX=clang++
-fi
-
-cd src
-unset MACOSX_DEPLOYMENT_TARGET
-# Supress tests failing for reason out of our controls
-FAILING_TESTS="CTestTestStopTime|TestUpload|ctest_submit"
-# gui interface may pull dependency conflicting with
-# sage libraries
-# (1) QT libraries
-FAILING_TESTS="${FAILING_TESTS}|Qt5Autogen|Qt4Autogen|Qt4Targets|Qt4And5AutomocReverse"
-# (2) GTK2
-FAILING_TESTS="${FAILING_TESTS}|GTK2Components|GTK2Targets"
-# BundleUtilities test is failing on some platforms, skipped in Gentoo for that reason
-FAILING_TESTS="${FAILING_TESTS}|BundleUtilities"
-# Test failing on freeBSD. Upstream acknoledged the test is faulty
-# on that platform https://gitlab.kitware.com/cmake/cmake/issues/16887
-if [ "$UNAME" = "FreeBSD" ]; then
-    FAILING_TESTS="${FAILING_TESTS}|RunCMake.GNUInstallDirs"
-fi
-ctest --extra-verbose --output-on-failure -E "(${FAILING_TESTS})"
+# Do not run a test suite: see https://trac.sagemath.org/ticket/30093.
+#
+# - The test suite takes a long time and can fail in minor ways.
+# - If some major aspect of cmake fails, it only affects the build
+#   process of Sage, not the mathematical correctness of its results.
+# - If some minor aspect of cmake fails, it won't affect anything about Sage.
 
+echo "We skip the test suite for cmake: see https://trac.sagemath.org/ticket/30093."
diff --git a/build/pkgs/curl/spkg-check.in b/build/pkgs/curl/spkg-check.in
index 27cd9419538..1e5337a2242 100644
--- a/build/pkgs/curl/spkg-check.in
+++ b/build/pkgs/curl/spkg-check.in
@@ -1,2 +1,8 @@
-cd src
-$MAKE check
+# Do not run a test suite: see https://trac.sagemath.org/ticket/30093.
+#
+# - The test suite takes a long time and can fail in minor ways.
+# - If some major aspect of curl fails, it only affects the build
+#   process of Sage, not the mathematical correctness of its results.
+# - If some minor aspect of curl fails, it won't affect anything about Sage.
+
+echo "We skip the test suite for curl: see https://trac.sagemath.org/ticket/30093."
diff --git a/build/pkgs/git/spkg-check.in b/build/pkgs/git/spkg-check.in
index 16858b7c7bb..b406e1dbbad 100644
--- a/build/pkgs/git/spkg-check.in
+++ b/build/pkgs/git/spkg-check.in
@@ -1,7 +1,8 @@
-# OSX Git with FSF GCC is broken, disable completely for now. See #17091
-export NO_APPLE_COMMON_CRYPTO=1
+# Do not run a test suite: see https://trac.sagemath.org/ticket/30093.
+#
+# - The test suite takes a long time and can often fail in minor ways.
+# - If some major aspect of git fails, it only affects the build
+#   process of Sage, not the mathematical correctness of its results.
+# - If some minor aspect of git fails, it won't affect anything about Sage.
 
-# Disable network tests
-export GIT_TEST_HTTPD=false
-
-cd src
+echo "We skip the test suite for git: see https://trac.sagemath.org/ticket/30093."