Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license file #1

Closed
tobiasdiez opened this issue Nov 25, 2023 · 6 comments
Closed

Add license file #1

tobiasdiez opened this issue Nov 25, 2023 · 6 comments

Comments

@tobiasdiez
Copy link

Needed for conda-forge/staged-recipes#24585.

@orlitzky
Copy link
Collaborator

The project metadata has

license = { text = "GPL-3.0-or-later" }

Is that not sufficient? Adding a copy of the GPLv3 only risks confusion IMO since someone might misinterpret that as being GPLv3-only.

@orlitzky
Copy link
Collaborator

(I'm not dead set against it, I could also include a COPYING file that says "or later" and point the pyproject.toml at COPYING, but then it just seems like a lot of effort to repeat a standard SPDX license identifier.)

@tobiasdiez
Copy link
Author

I don't have the legal background but my understanding is that the GNU licenses actually require you to distribute the exact full license text (eg https://opensource.stackexchange.com/questions/176/do-i-really-need-to-include-a-licence-file-for-common-licences-like-gpl-or-mit)

@orlitzky
Copy link
Collaborator

I guess Conda doesn't ship the usual licenses as part of the base install?

Upstream isn't bound by the GPLv3 yet, since we're the copyright holders and can do whatever we want. But distributions who redistribute the code are, so they would have to include a copy of the license. Debian and Gentoo get around it by shipping one copy of the license pointed to by the package metadata. But it looks like Fedora prefer the license file to be included, even though they still only install one copy to /usr/share/licenses.

I guess I'll just include them and not cause you headaches.

@tobiasdiez
Copy link
Author

Thanks! If you could push a new version, then we should get conda-forge/staged-recipes#24585 merged soon.

@orlitzky
Copy link
Collaborator

Done. I added some more examples and type hints to make a new version worthwhile. @mkoeppe will have to re-push the tag to get it on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants