Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 1.4.1 canonical contracts for Plume #882

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

eyqs
Copy link
Contributor

@eyqs eyqs commented Nov 25, 2024

Add new chain

Please fill the following form:

Provide the Chain ID (Only 1 chain id per PR).

  • Chain_ID: 98865

Provide RPC URL for the chain (should be able to query at least 3+ requests per second for automatic PR check).

Relevant information:

@eyqs eyqs requested review from gjeanmart and a team as code owners November 25, 2024 19:49
@mmv08
Copy link
Member

mmv08 commented Nov 26, 2024

ERROR: chain is not registered on Chainlist

@eyqs eyqs closed this Nov 27, 2024
@eyqs eyqs force-pushed the eyqs/plume-mainnet branch from 28b4987 to 8841705 Compare November 27, 2024 01:51
@eyqs eyqs reopened this Nov 27, 2024
@eyqs
Copy link
Contributor Author

eyqs commented Nov 27, 2024

@mmv08 @remedcu Would it be possible to deploy using the RPC URL with an API key here rather than the public RPC on Chainlist? We are gating access behind an API key before the mainnet launch.

@remedcu
Copy link
Member

remedcu commented Nov 27, 2024

You can deploy the contracts by following the steps mentioned here: https://github.com/safe-global/safe-smart-account/tree/v1.4.1-3

@eyqs
Copy link
Contributor Author

eyqs commented Nov 27, 2024

Hey @remedcu - all the contracts are deployed already to the canonical addresses! For example: https://explorer.plumenetwork.xyz/address/0xfd0732Dc9E303f09fCEf3a7388Ad10A83459Ec99

Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running manually:

npm run review:verify-deployment -s -- --version "v1.4.1" --chainId 98865 --rpc "https://phoenix-rpc.plumenetwork.xyz/FH7uok8YdCXHhBu4B18j632wpHogyMYan" --verbose
Parsed options:
{
  version: 'v1.4.1',
  chainId: '98865',
  rpc: 'https://phoenix-rpc.plumenetwork.xyz/',
  verbose: true
}
chain 98865 exists on Chainlist
RPC reported chain 98865
CompatibilityFallbackHandler deployments:
• canonical deployment OK
CreateCall deployments:
• canonical deployment OK
MultiSend deployments:
• canonical deployment OK
MultiSendCallOnly deployments:
• canonical deployment OK
Safe deployments:
• canonical deployment OK
SafeL2 deployments:
• canonical deployment OK
SafeMigration deployments:
• canonical deployment OK
SafeProxyFactory deployments:
• canonical deployment OK
SafeToL2Migration deployments:
• canonical deployment OK
SafeToL2Setup deployments:
• canonical deployment OK
SignMessageLib deployments:
• canonical deployment OK
SimulateTxAccessor deployments:
• canonical deployment OK

@remedcu remedcu merged commit f099b93 into safe-global:main Nov 27, 2024
2 of 4 checks passed
@eyqs eyqs deleted the eyqs/plume-mainnet branch November 27, 2024 21:53
@safe-global safe-global deleted a comment from eyqs Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants